Skip to content

Getting CRT to work with the new LArG4 - #207

Merged
pgreen135 merged 52 commits into
developfrom
feature/ilepetic_crtfix
Nov 19, 2021
Merged

pgreen135 merged 52 commits into
developfrom
feature/ilepetic_crtfix

Conversation

@ilepetic

@ilepetic ilepetic commented Nov 8, 2021

Copy link
Copy Markdown

This PR contains changes to sbndcode to allow the CRT to work with the new LArG4. This includes changes to the CRT detsim module and geometry. The geometry is changed to create individual logical volumes for each CRT scintillating strip (AuxDetSensitives). The strips are combined into an array (AuxDet).

Before this code is merged into develop, two other PRs must be completed:

  1. Adding tolerances when finding AuxDet(Sensitive)s LArSoft/larcorealg#23
  2. CRT translation module LArSoft/larsim#78

This PR closes #137 and closes #143.

@marcodeltutto

marcodeltutto commented Nov 9, 2021 •

Copy link
Copy Markdown
Member

Thank you @ilepetic! I just tried running it too and works all fine! One thing I have noticed is that we now have many more sim::AuxDetHit data products saved. I see about 2188 sim::AuxDetHit separate data products after the g4 stage, this is one product for each CRT sensitive volume. Am I doing something wrong or is this expected? Thanks!

Also, now that we have the CRT running, we should add this in the cosmics in-time and dirt workflows, and make sure we can make CRT-filtered samples. I'll open a separate issue to address these.

@ilepetic

ilepetic commented Nov 9, 2021

Copy link
Copy Markdown
Author

The separate data products for each AuxDetSensitive are expected.

@jzennamo

jzennamo commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

Do we need to propagate them or could they be dropped for file-size space savings?

@ilepetic

ilepetic commented Nov 9, 2021

Copy link
Copy Markdown
Author

sim::AuxDetHits are not necessary after the G4 stage, so they are now dropped.

@marcodeltutto marcodeltutto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilepetic, thanks again! All looks good to me. The only thing I noticed is that you have generated sbnd_v02_00.gdml and sbnd_v02_00_nowires.gdml but not the equivalent ones with the overburden. Could you please also run

preparseGDML sbnd_v02_00_base.gdml -w -S DefaultWithShielding -o sbnd_v02_00_withshielding.gdml

and commit the two files with the overburden too? Thanks!

I am a bit concerned with the fact that we now have >1000 separate data-products saved in the event, one for each CRT strip. M concern is not about the file size as we are now dropping them, but on the fact that this makes the files quite hard to navigate now. Parsing the output of eventdump.fcl is now very hard; even after the products are dropped, they are still listed with a ? under product size. Maybe there is a way to completely get rid of them I am not aware of? @jzennamo @wesketchum.

@ilepetic my understanding is that this is unavoidable because the new larg4 makes separate instances for each volAuxDetSensitive, and we cannot assign the same name to all the CRTs volAuxDetSensitive of the same type as it was before, because LArSoft geometry expects different names. Is my understanding correct? If so, maybe in the future we can talk to the LArSoft team and see what we can do about this, maybe LArG4 could merge all the AuxDetHits collections before placing them into the Event, just a thought.

Thank you again!

@ilepetic

Copy link
Copy Markdown
Author

GDML files with shielding have been added.

@marcodeltutto, that is my understanding as well.

@marcodeltutto
marcodeltutto self-requested a review November 10, 2021 19:12
@pgreen135

Copy link
Copy Markdown
Member

trigger build

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@pgreen135

Copy link
Copy Markdown
Member

trigger build LArSoft/larcorealg#23 LArSoft/larsim#78

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@pgreen135

pgreen135 commented Nov 11, 2021 •

Copy link
Copy Markdown
Member

@ilepetic now builds correctly (missed the dependencies before!), but there are some failures at the detsim stage:

%MSG-s ArtException:  PostEndJob 11-Nov-2021 06:51:05 CST ModuleEndJob
62: ---- EventProcessorFailure BEGIN
63:   EventProcessor: an exception occurred during current event processing
64:   ---- ScheduleExecutionFailure BEGIN
65:     Path: ProcessingStopped.
66:     ---- ProductNotFound BEGIN
67:       Found zero products matching all selection criteria
68:         C++ type: std::vector<sim::AuxDetSimChannel>
69:         Module label: 'genericcrt'
70:         Product instance name: ''
71:         Process name: (empty)The above exception was thrown while processing module sbndcode/CRT/CRTDetSim/crt run: 1 subRun: 0 event: 1
72:     ---- ProductNotFound END
73:     Exception going through path simulate
74:   ---- ScheduleExecutionFailure END
75: ---- EventProcessorFailure END
76: %MSG

@henrylay97

Copy link
Copy Markdown
Member

Due to the nature of this PR we've triggered CI builds to use the sequential testing method (i.e. running all stages back to back rather than using old references as the inputs for each stage. These tests are not useful for showing product size differences but should prove end to end workflow (as the detsim error shows above). I'll post their results here when ready :)

@pgreen135

Copy link
Copy Markdown
Member

trigger build

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce Number of LArG4 AuxDetHits CRT Compatibility with the Refactored LArG4 CRT Geometry in v02_00