Repository navigation
Getting CRT to work with the new LArG4 - #207
Conversation
|
Thank you @ilepetic! I just tried running it too and works all fine! One thing I have noticed is that we now have many more Also, now that we have the CRT running, we should add this in the cosmics in-time and dirt workflows, and make sure we can make CRT-filtered samples. I'll open a separate issue to address these. |
|
The separate data products for each AuxDetSensitive are expected. |
|
Do we need to propagate them or could they be dropped for file-size space savings? |
|
sim::AuxDetHits are not necessary after the G4 stage, so they are now dropped. |
marcodeltutto
left a comment
There was a problem hiding this comment.
Hi @ilepetic, thanks again! All looks good to me. The only thing I noticed is that you have generated sbnd_v02_00.gdml and sbnd_v02_00_nowires.gdml but not the equivalent ones with the overburden. Could you please also run
preparseGDML sbnd_v02_00_base.gdml -w -S DefaultWithShielding -o sbnd_v02_00_withshielding.gdmland commit the two files with the overburden too? Thanks!
I am a bit concerned with the fact that we now have >1000 separate data-products saved in the event, one for each CRT strip. M concern is not about the file size as we are now dropping them, but on the fact that this makes the files quite hard to navigate now. Parsing the output of eventdump.fcl is now very hard; even after the products are dropped, they are still listed with a ? under product size. Maybe there is a way to completely get rid of them I am not aware of? @jzennamo @wesketchum.
@ilepetic my understanding is that this is unavoidable because the new larg4 makes separate instances for each volAuxDetSensitive, and we cannot assign the same name to all the CRTs volAuxDetSensitive of the same type as it was before, because LArSoft geometry expects different names. Is my understanding correct? If so, maybe in the future we can talk to the LArSoft team and see what we can do about this, maybe LArG4 could merge all the AuxDetHits collections before placing them into the Event, just a thought.
Thank you again!
|
GDML files with shielding have been added. @marcodeltutto, that is my understanding as well. |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c7:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/larcorealg#23 LArSoft/larsim#78 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
@ilepetic now builds correctly (missed the dependencies before!), but there are some failures at the detsim stage: |
|
Due to the nature of this PR we've triggered CI builds to use the sequential testing method (i.e. running all stages back to back rather than using old references as the inputs for each stage. These tests are not useful for showing product size differences but should prove end to end workflow (as the detsim error shows above). I'll post their results here when ready :) |
… any previous dirt fcl
…d HitDumper module to analyze it
…m data) to defult for XArapucas and ideal SER for PMTs
…use tolerance; tolerance hard-coded in the function
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
This PR contains changes to sbndcode to allow the CRT to work with the new LArG4. This includes changes to the CRT detsim module and geometry. The geometry is changed to create individual logical volumes for each CRT scintillating strip (AuxDetSensitives). The strips are combined into an array (AuxDet).
Before this code is merged into develop, two other PRs must be completed:
This PR closes #137 and closes #143.