Skip to content

More CRT Segfaults - #246

Merged
pgreen135 merged 2 commits into
release/SBN2021Cfrom
bugfix/hlay_more_crt_segfaults
Jan 14, 2022
Merged

pgreen135 merged 2 commits into
release/SBN2021Cfrom
bugfix/hlay_more_crt_segfaults

Conversation

@henrylay97

@henrylay97 henrylay97 commented Jan 11, 2022 •

Copy link
Copy Markdown
Member

This further patches CRT segfaults related to those addressed in #240. These segfaults originated in the introduction of the refactored larg4 for the CRT (#207). These are "rare" segfaults, hence they were discovered in production where the volume of events was high enough to see this occur regularly.

This has been 'tested' in production by using a tarred version of the code. It fixes the issue we were seeing.

@marcodeltutto marcodeltutto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @henrylay97!

I confirm that this should fix the segfault. I was able to reproduce the issue and gdb traced it back to this line:

geo::AuxDetGeo const& adg = auxDets[auxDetIdx];

which is exactly what is being fixed by this PR.


gdb output:

[...]
Skip SimEnergyDeposit in: LArG4DetectorServicevolCryostat
Skip SimEnergyDeposit in: LArG4DetectorServicevolXArapuca

Thread 1 "lar" received signal SIGSEGV, Segmentation fault.
geo::ChannelMapSBNDAlg::NearestSensitiveAuxDet (this=<optimized out>, point=0x7ffffffe1540, auxDets=..., tolerance=0.0001)
    at /scratch/workspace/sbndcode-release-build/BUILDTYPE/prof/QUAL/e20/label1/swarm/label2/SLF7/temp/srcs/sbndcode/sbndcode/Geometry/ChannelMapSBNDAlg.cxx:53

@henrylay97

Copy link
Copy Markdown
Member Author

Ah wonderful, very grateful you were able to actually establish a definite test @marcodeltutto

@pgreen135
pgreen135 merged commit 5ca176c into release/SBN2021C Jan 14, 2022
@pgreen135
pgreen135 deleted the bugfix/hlay_more_crt_segfaults branch April 15, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants