Repository navigation
More CRT Segfaults - #246
Merged
Merged
Conversation
henrylay97
requested review from
ilepetic,
jzennamo,
marcodeltutto and
mattfcs
January 11, 2022 15:45
ilepetic
approved these changes
Jan 11, 2022
marcodeltutto
approved these changes
Jan 12, 2022
marcodeltutto
left a comment
Member
There was a problem hiding this comment.
Thanks, @henrylay97!
I confirm that this should fix the segfault. I was able to reproduce the issue and gdb traced it back to this line:
geo::AuxDetGeo const& adg = auxDets[auxDetIdx];which is exactly what is being fixed by this PR.
gdb output:
[...]
Skip SimEnergyDeposit in: LArG4DetectorServicevolCryostat
Skip SimEnergyDeposit in: LArG4DetectorServicevolXArapuca
Thread 1 "lar" received signal SIGSEGV, Segmentation fault.
geo::ChannelMapSBNDAlg::NearestSensitiveAuxDet (this=<optimized out>, point=0x7ffffffe1540, auxDets=..., tolerance=0.0001)
at /scratch/workspace/sbndcode-release-build/BUILDTYPE/prof/QUAL/e20/label1/swarm/label2/SLF7/temp/srcs/sbndcode/sbndcode/Geometry/ChannelMapSBNDAlg.cxx:53
Member
Author
|
Ah wonderful, very grateful you were able to actually establish a definite test @marcodeltutto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This further patches CRT segfaults related to those addressed in #240. These segfaults originated in the introduction of the refactored larg4 for the CRT (#207). These are "rare" segfaults, hence they were discovered in production where the volume of events was high enough to see this occur regularly.
This has been 'tested' in production by using a tarred version of the code. It fixes the issue we were seeing.