Skip to content

change genieweight fhicl, universes 100->20 - #203

Merged
miquelnebot merged 1 commit into
developfrom
feature/keng_speedup_genie_eventweight
Nov 19, 2021
Merged

miquelnebot merged 1 commit into
developfrom
feature/keng_speedup_genie_eventweight

Conversation

@Ooohu

@Ooohu Ooohu commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

For current genie weight calculators: it takes 1.5 minute to prepare 50 knob for each universe. This effect is linear such that we can speed up the code by using less universes; say 20, then we only need 30 mins to prepare knobs.

@Ooohu
Ooohu requested a review from jzennamo November 19, 2021 16:32

@jzennamo jzennamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@jzennamo

Copy link
Copy Markdown
Contributor

trigger build

@cjbacchus

Copy link
Copy Markdown
Contributor

I'm suspicious of the utility of 20 universes for analysis purposes. It seems like the real fix has to be to figure out how to speed up the initialization. We had genie knobs before with a reasonable runtime. I understand that might not be possible in time for the production, but you should understand that it's likely to become a "technology demo" rather than anything actually usable.

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

SBND CI fails seem to be caused by std::vector<sim::AuxDetSimChannel> apparently introduced in the CRT SBNSoftware/sbndcode#207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants