Repository navigation
Fix for CRT detsim and reco - #228
Conversation
…AuxDetSensitives of the same type now all have the same name
jzennamo
left a comment
There was a problem hiding this comment.
I cannot say I am an expert on the ins and outs of the code but this looks reasonable and Marco says he did checks that behave as expected! Thanks Marco!
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
With PR #207 we are using a CRT geometry that uses the same logical volumes for CRT strips of the same type. This caused the CRT detsim and reco to always pick the first CRT strip declared in the GDML.
This PR fixes this problem by changing the logic in which the CRT geometry nodes are found. Now, the unique
AuxDetvolume is identified first, and then the code descends from it to find the strip (AuxDetSensitive).