Skip to content

Fix for CRT detsim and reco - #228

Merged
pgreen135 merged 2 commits into
developfrom
mdeltutt_crtstrips
Nov 20, 2021
Merged

pgreen135 merged 2 commits into
developfrom
mdeltutt_crtstrips

Conversation

@marcodeltutto

Copy link
Copy Markdown
Member

With PR #207 we are using a CRT geometry that uses the same logical volumes for CRT strips of the same type. This caused the CRT detsim and reco to always pick the first CRT strip declared in the GDML.

This PR fixes this problem by changing the logic in which the CRT geometry nodes are found. Now, the unique AuxDet volume is identified first, and then the code descends from it to find the strip (AuxDetSensitive).

@jzennamo jzennamo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot say I am an expert on the ins and outs of the code but this looks reasonable and Marco says he did checks that behave as expected! Thanks Marco!

@jzennamo

Copy link
Copy Markdown
Contributor

trigger build

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@pgreen135
pgreen135 merged commit b9f3c5d into develop Nov 20, 2021
@pgreen135
pgreen135 deleted the mdeltutt_crtstrips branch December 7, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants