Skip to content

Calibration NTuple Update - #196

Merged
miquelnebot merged 5 commits into
developfrom
feature/gputnam-calib-calo-local
Nov 19, 2021
Merged

miquelnebot merged 5 commits into
developfrom
feature/gputnam-calib-calo-local

Conversation

@gputnam

@gputnam gputnam commented Nov 15, 2021 •

Copy link
Copy Markdown
Contributor

Refine truth matching variables; add in SCE corrected versions where useful; add in an addition Hit truth backtracking method.

Depends on SBNSoftware/sbnobj#33.

@gputnam

gputnam commented Nov 15, 2021

Copy link
Copy Markdown
Contributor Author

PR should be good to go!

@wesketchum wesketchum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbnobj#33

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

@gputnam CI failed, can you check it, please?

@gputnam

gputnam commented Nov 18, 2021

Copy link
Copy Markdown
Contributor Author

I have looked at the errors. AFAICT, they seem to be caused by some CORSIKA files not being read correctly.

For example:
77: dd: error reading '/cvmfs/sbn.osgstorage.org/pnfs/fnal.gov/usr/sbn/persistent/stash/physics/cosmics/Fermilab/CORSIKA/standard/v01_00/p_showers_085086.db': Input/output error

I don't think these errors actually represent a problem with the code.

@miquelnebot

Copy link
Copy Markdown
Contributor

cvmfs access issues should be resolved by now.

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbnobj#33

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@gputnam

gputnam commented Nov 18, 2021

Copy link
Copy Markdown
Contributor Author

The ICARUS failure seems to be caused by a broken fcl file unrelated to this PR: https://dbweb8.fnal.gov:8443/LarCI/app/ns:icarus/storage/docs/2021/11/18/testFHiCLfiles_icarus.sh%23uUt4gWL.log.

The SBND failure can be traced to this function in the SpaceCharge service: https://github.com/SBNSoftware/sbndcode/blob/develop/sbndcode/SpaceCharge/SpaceChargeSBND.cxx#L240. If the SpaceCharge is configured to be off and one calls the GetCalPosOffsets function, it segfaults.

This seems to me like a bug in the SpaceCharge service, but I have put in a patch to work around it.

With the above commit the CI should work now.

@miquelnebot

Copy link
Copy Markdown
Contributor

Thanks for the @gputnam !
the ICARUS one now should be fixed by @henrylay97 's #200 too

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbnobj#33

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

The ICARUS failure seems to be caused by a broken fcl file unrelated to this PR: https://dbweb8.fnal.gov:8443/LarCI/app/ns:icarus/storage/docs/2021/11/18/testFHiCLfiles_icarus.sh%23uUt4gWL.log.

The SBND failure can be traced to this function in the SpaceCharge service: https://github.com/SBNSoftware/sbndcode/blob/develop/sbndcode/SpaceCharge/SpaceChargeSBND.cxx#L240. If the SpaceCharge is configured to be off and one calls the GetCalPosOffsets function, it segfaults.

This seems to me like a bug in the SpaceCharge service, but I have put in a patch to work around it.

With the above commit the CI should work now.

Actually the ICARUS fail apparently comes from #193 (review)
@gputnam could you fix that?

@gputnam

gputnam commented Nov 18, 2021

Copy link
Copy Markdown
Contributor Author

Just did!

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbnobj#33

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbnobj#33

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

finally fixed ICARUS CI failures successful. (new SBND fail due to SBNSoftware/sbndcode#207, but was clean before)
So good to go.

@miquelnebot
miquelnebot merged commit f29cf30 into develop Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants