Repository navigation
fix: Tauri viewer loads the HTTP server URL instead of serving files from disk - #157
Merged
Merged
Conversation
… files from disk The viewer's fastled:// custom protocol read the output directory directly, so a fresh sketch with no index.html rendered a bare "Not Found" and never recovered -- the loading page, SSE build log, auto-reload, and error UX all live in the HTTP server the viewer never touched. The webview now loads the server URL, sharing one code path with the browser; COOP/COEP headers come from the server. Closes #156 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Jun 11, 2026
zackees
added a commit
that referenced
this pull request
Jun 12, 2026
…est stale copies (#166) pip install . could ship a binary that predates the current source: ensure_bundled_fastled_binary() early-returned on any pre-existing src/fastled/bin/fastled[.exe], harvested old exes from ~/.cargo/bin, and pip's wheel cache reused stale 2.0.10 wheels because the version never changed. The viewer fix from #157 was effectively uninstallable. - setup.py: when Cargo.toml is present, purge stale bundled binaries (including build/lib copies) and always run soldr cargo build; drop the CARGO_HOME harvest; refresh the copied binary's mtime so setuptools' newer-checks can't keep stale build/lib copies. - Bump workspace version to 2.0.11 so the pip wheel cache key changes. - Add FASTLED_VIEWER_LOGS: the Tauri viewer injects a console/error forwarding script that POSTs to the server's new /viewer-log endpoint, which echoes lines to stderr for diagnosability. - Regression tests for the staleness paths and the new endpoint. Closes #165 Refs #160 Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
zackees
added a commit
that referenced
this pull request
Jun 12, 2026
Bumps workspace version 2.0.10 -> 2.0.11 so the auto-release workflow ships the first release containing 0332caf (#157), which points the Tauri viewer at the HTTP server instead of serving files from disk. Adds a fail-loud http(s) URL check in launch_tauri_viewer plus unit tests rejecting directory paths and fastled:// URLs, so a regression back to disk-backed viewing fails tests instead of shipping a dead "Not Found" window. Closes #160 Refs #151 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
zackees
added a commit
that referenced
this pull request
Jun 12, 2026
…161) Bumps workspace version 2.0.10 -> 2.0.11 so the auto-release workflow ships the first release containing 0332caf (#157), which points the Tauri viewer at the HTTP server instead of serving files from disk. Adds a fail-loud http(s) URL check in launch_tauri_viewer plus unit tests rejecting directory paths and fastled:// URLs, so a regression back to disk-backed viewing fails tests instead of shipping a dead "Not Found" window. Closes #160 Refs #151 Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #156
Summary
fastled://custom protocol; on a fresh sketch (noindex.htmlyet) it rendered a bare "Not Found" and never recovered, bypassing the loading page (feat: instant launch — explicit failure UX in the loading page #149), live compile log streaming (feat: live colored compile log streaming in browser loading page (spinner only, no progress bar) #153/feat: live colored compile log streaming in browser loading page #154), and failure UX entirely.WebviewUrl::External), so viewer and browser share one code path: loading page while compiling, SSE colored build log, auto-reload on success, explicit error state on fatal compile/link errors.--internal-viewernow takes an http(s) URL and fails loud on anything else; the custom protocol handler is deleted (COOP/COEP headers come from the HTTP server, which already sets them).Tests
soldr cargo test --workspace— 135 passed (includes updatedtest_viewer_command_uses_internal_viewer_flag)bash lint— fmt + clippy clean; dylint phase fails with the pre-existingdylint_driver5.0.0 / rustc 1.94.1 incompatibility, same as mainfastled --internal-viewer <dir>fails loud with a clear error; viewer launched against a live local HTTP URL opens and stays up🤖 Generated with Claude Code