Skip to content

fix: Tauri viewer loads the HTTP server URL instead of serving files from disk - #157

Merged
zackees merged 1 commit into
mainfrom
fix/viewer-http-url
Jun 11, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/viewer-http-url

Conversation

@zackees

@zackees zackees commented Jun 11, 2026

Copy link
Copy Markdown
Member

Closes #156

Summary

Tests

  • soldr cargo test --workspace — 135 passed (includes updated test_viewer_command_uses_internal_viewer_flag)
  • bash lint — fmt + clippy clean; dylint phase fails with the pre-existing dylint_driver 5.0.0 / rustc 1.94.1 incompatibility, same as main
  • Smoke: fastled --internal-viewer <dir> fails loud with a clear error; viewer launched against a live local HTTP URL opens and stays up

🤖 Generated with Claude Code

… files from disk

The viewer's fastled:// custom protocol read the output directory
directly, so a fresh sketch with no index.html rendered a bare
"Not Found" and never recovered -- the loading page, SSE build log,
auto-reload, and error UX all live in the HTTP server the viewer
never touched. The webview now loads the server URL, sharing one
code path with the browser; COOP/COEP headers come from the server.

Closes #156

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@zackees
zackees merged commit 0332caf into main Jun 11, 2026
24 of 25 checks passed
@zackees
zackees deleted the fix/viewer-http-url branch June 11, 2026 23:11
zackees added a commit that referenced this pull request Jun 12, 2026
…est stale copies (#166)

pip install . could ship a binary that predates the current source:
ensure_bundled_fastled_binary() early-returned on any pre-existing
src/fastled/bin/fastled[.exe], harvested old exes from ~/.cargo/bin,
and pip's wheel cache reused stale 2.0.10 wheels because the version
never changed. The viewer fix from #157 was effectively uninstallable.

- setup.py: when Cargo.toml is present, purge stale bundled binaries
  (including build/lib copies) and always run soldr cargo build; drop
  the CARGO_HOME harvest; refresh the copied binary's mtime so
  setuptools' newer-checks can't keep stale build/lib copies.
- Bump workspace version to 2.0.11 so the pip wheel cache key changes.
- Add FASTLED_VIEWER_LOGS: the Tauri viewer injects a console/error
  forwarding script that POSTs to the server's new /viewer-log
  endpoint, which echoes lines to stderr for diagnosability.
- Regression tests for the staleness paths and the new endpoint.

Closes #165
Refs #160

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
zackees added a commit that referenced this pull request Jun 12, 2026
Bumps workspace version 2.0.10 -> 2.0.11 so the auto-release workflow
ships the first release containing 0332caf (#157), which points the
Tauri viewer at the HTTP server instead of serving files from disk.

Adds a fail-loud http(s) URL check in launch_tauri_viewer plus unit
tests rejecting directory paths and fastled:// URLs, so a regression
back to disk-backed viewing fails tests instead of shipping a dead
"Not Found" window.

Closes #160
Refs #151

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
zackees added a commit that referenced this pull request Jun 12, 2026
…161)

Bumps workspace version 2.0.10 -> 2.0.11 so the auto-release workflow
ships the first release containing 0332caf (#157), which points the
Tauri viewer at the HTTP server instead of serving files from disk.

Adds a fail-loud http(s) URL check in launch_tauri_viewer plus unit
tests rejecting directory paths and fastled:// URLs, so a regression
back to disk-backed viewing fails tests instead of shipping a dead
"Not Found" window.

Closes #160
Refs #151

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Tauri viewer shows "Not Found" instead of compile loading page (bypasses HTTP server)

1 participant