Repository navigation
Conversation
…ctory protocol The instant-launch viewer was loading fastled://localhost/index.html via a custom protocol that served raw files from the artifact directory. On a cold compile index.html does not exist yet, so the viewer rendered a static "Not Found" page with no JavaScript and never recovered, even after the build succeeded. Replace the custom protocol with an external WebviewUrl pointing at the embedded HTTP server, which already serves the loading page with SSE build streaming and auto-reloads into the sketch when the build completes. Closes #151 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
11 tasks
Member
Author
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151
Summary
fastled://localhost/index.htmlvia a custom protocol serving raw files from the artifact directory. On a cold compileindex.htmldoesn't exist yet, so the viewer showed a static "Not Found" page with no JS and never recovered — even after the build succeeded.fastled://custom protocol entirely and point the viewer (--internal-viewer-url) at the embedded HTTP server, which already serves the loading page with SSE build streaming and auto-reloads into the sketch when the build finishes.Test plan
soldr cargo test --workspace— 131 tests passbash lint— fmt and clippy clean (dylint step fails identically onmain: pre-existingdylint_driverv5.0.0 build break against nightly-2026-03-26, unrelated to this change)fastled_js/+.build/to force a full cold compile): viewer spawned with--internal-viewer-url http://127.0.0.1:<port>, showed the loading page with spinner + live compile log mid-build, then auto-transitioned to the rendered sketch UI in the same session — no restart needed🤖 Generated with Claude Code