Repository navigation
Conversation
ensure_bundled_fastled_binary previously returned early whenever any exe existed in src/fastled/bin, so `pip install .` silently bundled days-old binaries (how a pre-#157 viewer shipped despite a fresh install). Now the staged exe is only trusted when it is at least as new as every Rust source (Cargo.toml, Cargo.lock, crates/**); anything older triggers a soldr-cached `cargo build --release` so the wheel always matches the checkout. CI is unaffected: it stages a freshly cross-compiled exe immediately before building the wheel. Also picks the newest built candidate instead of the first match and drops the ~/.cargo/bin fallback, which could bundle an unrelated binstall-installed fastled. Refs #151, #160 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
Author
|
Superseded by #166, which fixed the same staleness bug more aggressively: when Cargo.toml is present, setup.py now always runs 'soldr cargo build --release --bin fastled', purges stale staged binaries (src/fastled/bin + build/lib*), and removed the CARGO_HOME fallback. Merged to main as part of v2.0.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install .previously bundled whatever exe was already sitting insrc/fastled/bin/—ensure_bundled_fastled_binaryreturned early if the file existed, regardless of age. That's how a June 7 (pre-fix: Tauri viewer loads the HTTP server URL instead of serving files from disk #157) viewer binary shipped from a June 11 fresh install (refs fix: instant launch broken — Tauri viewer loads fastled:// directory protocol, never the HTTP server, shows 'Not Found' forever #151/release: cut v2.0.11 with viewer fix #157 + add viewer-wiring regression gate #160).Cargo.toml,Cargo.lock,crates/**). Stale or missing ->soldr cargo build --release --bin fastled(soldr/zccache makes the rebuild cheap), then the newest built candidate is staged.~/.cargo/bin/fastledfallback (could bundle an unrelated binstall-installed binary) and switched candidate selection from first-match to newest-by-mtime._build.ymlstages a freshly cross-compiled exe immediately beforebdist_wheel, so the freshness check passes and no host rebuild occurs.Test plan
pip wheel . --no-depstriggers the soldr build; resulting binary rejects--internal-viewer not-a-url(post-fix: Tauri viewer loads the HTTP server URL instead of serving files from disk #157 behavior confirmed)pip wheel .skips the rebuild (~12s total)pip wheel .rebuilds and restores a fresh binaryruff/black/isortclean on setup.py🤖 Generated with Claude Code