Skip to content

release: cut v2.0.11 with viewer fix #157 + add viewer-wiring regression gate #160

Closed

Description

@zackees

Context

The "Not Found" viewer bug (#151) was fixed by #157 (0332caf, merged 2026-06-11), but no release contains the fix. The latest release is v2.0.10 (eb37820), cut before 0332caf landed. Any pip install fastled — or a pip install . from a checkout at/behind 3fa9737 — ships a binary where the Tauri viewer loads fastled://localhost/index.html straight from disk (crates/fastled-cli/src/tauri_viewer.rs:54-72 pre-fix). The viewer launches before the compile writes index.html, the custom-protocol handler returns a literal static "Not Found" body with no JS/SSE/reload, and the window stays stuck there forever even though the build succeeds and the HTTP server at 127.0.0.1:<port> serves the sketch correctly.

Reproduced today on Windows: fresh pip install . from main@3fa9737, compile of examples\TwinkleFox succeeds, output fastled_js/index.html exists and is correct, viewer still shows "Not Found".

A second gap: this regressed/slipped twice (PR #152 closed unmerged, #157 merged post-release) because the existing tests only exercise the HTTP server surface (crates/fastled-cli/src/server.rs tests). Nothing asserts the viewer is actually wired to the HTTP server.

Proposal

  1. Cut and publish v2.0.11 from current main (must include 0332caf), so pip install fastled carries the viewer fix.
  2. Add a regression test in crates/fastled-cli asserting the viewer launch path uses the HTTP server URL — e.g. the spawned viewer command line contains --internal-viewer-url http://... (or equivalent assertion that WebviewUrl::External(http://...) is used and the fastled:// disk protocol is not the navigation target).

Acceptance criteria

Decisions

  • Priority: P1 — every released install is broken on the primary UX path (viewer), and the fix already exists.
  • Scope: release + test gate only; the code fix itself is already merged (fix: Tauri viewer loads the HTTP server URL instead of serving files from disk #157), so no further viewer code changes proposed here.
  • Test location: crates/fastled-cli/src/viewer.rs unit test on the spawned command args — cheapest assertion that catches this class of regression without a GUI harness.

Related issues

Activity

  1. added a commit that references this issue on Jun 12, 2026
    04dccd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions