Repository navigation
Description
Context
The "Not Found" viewer bug (#151) was fixed by #157 (0332caf, merged 2026-06-11), but no release contains the fix. The latest release is v2.0.10 (eb37820), cut before 0332caf landed. Any pip install fastled — or a pip install . from a checkout at/behind 3fa9737 — ships a binary where the Tauri viewer loads fastled://localhost/index.html straight from disk (crates/fastled-cli/src/tauri_viewer.rs:54-72 pre-fix). The viewer launches before the compile writes index.html, the custom-protocol handler returns a literal static "Not Found" body with no JS/SSE/reload, and the window stays stuck there forever even though the build succeeds and the HTTP server at 127.0.0.1:<port> serves the sketch correctly.
Reproduced today on Windows: fresh pip install . from main@3fa9737, compile of examples\TwinkleFox succeeds, output fastled_js/index.html exists and is correct, viewer still shows "Not Found".
A second gap: this regressed/slipped twice (PR #152 closed unmerged, #157 merged post-release) because the existing tests only exercise the HTTP server surface (crates/fastled-cli/src/server.rs tests). Nothing asserts the viewer is actually wired to the HTTP server.
Proposal
- Cut and publish v2.0.11 from current
main(must include0332caf), sopip install fastledcarries the viewer fix. - Add a regression test in
crates/fastled-cliasserting the viewer launch path uses the HTTP server URL — e.g. the spawned viewer command line contains--internal-viewer-url http://...(or equivalent assertion thatWebviewUrl::External(http://...)is used and thefastled://disk protocol is not the navigation target).
Acceptance criteria
- v2.0.11 release published;
pip install fastled==2.0.11followed byfastledon a sketch repo shows the loading page then the compiled sketch in the viewer (no "Not Found"). - A
soldr cargo test --workspacetest fails if the viewer is launched with a directory/fastled://target instead of anhttp://URL. - fix: instant launch broken — Tauri viewer loads fastled:// directory protocol, never the HTTP server, shows 'Not Found' forever #151 closed once verified against the released wheel.
Decisions
- Priority: P1 — every released install is broken on the primary UX path (viewer), and the fix already exists.
- Scope: release + test gate only; the code fix itself is already merged (fix: Tauri viewer loads the HTTP server URL instead of serving files from disk #157), so no further viewer code changes proposed here.
- Test location:
crates/fastled-cli/src/viewer.rsunit test on the spawned command args — cheapest assertion that catches this class of regression without a GUI harness.
Related issues
- fix: instant launch broken — Tauri viewer loads fastled:// directory protocol, never the HTTP server, shows 'Not Found' forever #151 (open) — the underlying bug; this issue covers shipping its fix and preventing recurrence.
- fix: Tauri viewer shows "Not Found" instead of compile loading page (bypasses HTTP server) #156 (closed) / fix: point Tauri viewer at HTTP server URL instead of fastled:// protocol #152 (closed unmerged) / fix: Tauri viewer loads the HTTP server URL instead of serving files from disk #157 (merged fix
0332caf).
Activity
fix(packaging): always rebuild the bundled fastled binary; never harv…
release: v2.0.11 with viewer fix #157 and viewer URL regression gate
release: v2.0.11 with viewer fix #157 and viewer URL regression gate (#…