Repository navigation
feat: live colored compile log streaming in browser loading page - #154
Merged
Merged
Conversation
…ostics Build subprocesses previously ran with inherited stdio, so the loading page's SSE log panel only received a one-line summary after the build finished. Spawn them with piped stdout/stderr instead, forwarding each line through a LogSink to both the terminal and the SSE broadcast as it is produced (PYTHONUNBUFFERED keeps the Python-driven tools line-buffered). The loading page now renders per-line log entries with warnings in yellow and errors in red, follows the tail unless the user scrolls up, and jumps to the first diagnostic on failure. Success is only reported when index.html actually exists on disk, so a fatal compile or link error can never reload the page into a blank view; the SSE connection stays open so a later fixed rebuild recovers in the same session. Closes #153 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Closed
5 tasks
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153
Summary
LogSinkto the terminal and the SSE/build-streamchannel as it is produced — previously they inherited stdio and the browser only got a one-line summary after the build returned.PYTHONUNBUFFERED=1keeps the Python-driven tools line-buffered.[WASM]progress markers go through the same sink.<div>s (textContent — no HTML injection):warning:lines in yellow,error:/fatal error/undefined symbol/stderr-failure lines in red. Auto-scroll follows the tail unless the user scrolls up; on failure it jumps to the first diagnostic. The spinner remains the only activity indicator (no progress bar — step counts are unknowable).successis only published (SSE +build-status.json) whenindex.htmlactually exists on disk, so an error can never reload the page into a blank view; the SSE connection stays open after an error, and a later fixed rebuild recovers to the sketch in the same session.Test plan
soldr cargo test --workspace— 136 tests pass (4 new: pipedrun_statusstreaming + failure,report_build_outcomeindex-gating, loading-page classification/no-progress-bar markers)bash lint— fmt and clippy clean (dylint step fails identically onmain: pre-existingdylint_driverbuild break, unrelated)use of undeclared identifiererror (freshfastled_js/): 48 log lines streamed live over/build-streamduring the build, compiler error line delivered with"stream":"stderr",build-status.jsonand SSE reporterror,/keeps serving the loading page (no index.html, no reload)compiling→success,index.htmlwas produced, and/served the real sketch — same CLI session, no restart🤖 Generated with Claude Code