Skip to content

ui: fix columns for exportacls csv - #9118

Merged
shwstppr merged 2 commits into
apache:4.19from
shapeblue:fix-ui-exportaclports
May 28, 2024
Merged

ui: fix columns for exportacls csv#9118
shwstppr merged 2 commits into
apache:4.19from
shapeblue:fix-ui-exportaclports

Conversation

@shwstppr

@shwstppr shwstppr commented May 24, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #8862

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

ACL rules
image

CSV
image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: fix columns for exportacls csv
9835310 
Fixes apache#8862

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr mentioned this pull request May 24, 2024
Closed
@codecov

codecov Bot commented May 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (87e7c57) to head (7d8bacd).
Report is 6 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9118      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10985      -10     
============================================
  Files          5373     5373              
  Lines        469005   469027      +22     
  Branches      58953    59611     +658     
============================================
- Hits          70198    70169      -29     
- Misses       391036   391092      +56     
+ Partials       7771     7766       -5
Flag Coverage Δ
uitests 4.31% <ø> (-0.01%) ⬇️
unittests 15.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache

weizhouapache commented May 24, 2024

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9118 (QA-JID-352)

@weizhouapache

weizhouapache commented May 24, 2024

Copy link
Copy Markdown
Member

thanks @shwstppr

tested on https://qa.cloudstack.cloud/simulator/pr/9118/#/acllist/5f3185d4-4b78-4cc1-83fd-2fe141f730f2?tab=acl.list.rules
it looks startport and endport are missing
image

@shwstppr
fix
7d8bacd 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

shwstppr commented May 24, 2024

Copy link
Copy Markdown
Contributor Author

@weizhouapache should be fixed now

image

@blueorangutan ui

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9118 (QA-JID-354)

@weizhouapache

weizhouapache commented May 24, 2024

Copy link
Copy Markdown
Member

thanks @shwstppr

it works now

image

@weizhouapache weizhouapache added this to the 4.19.1.0 milestone May 24, 2024
vishesh92
vishesh92 approved these changes May 27, 2024
View reviewed changes

@vishesh92 vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr
shwstppr merged commit c07953c into apache:4.19 May 28, 2024
@shwstppr
shwstppr deleted the fix-ui-exportaclports branch May 28, 2024 06:40
DaanHoogland added a commit that referenced this pull request May 28, 2024
@DaanHoogland
Merge release branch 4.19 to main
f1c3d2c 
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (#9120)
  ui: fix create menu item access (#9104)
  server: honor listall param for listiso api (#9064)
  ui: add move to top/bottom for acl rules list (#9119)
  ui: fix columns for exportacls csv (#9118)
  ui: fix create network access in deploy vm wizard (#9117)
  UI: Add search filters (#9068)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@shwstppr @dhslove
ui: fix columns for exportacls csv (apache#9118)
3475fb3 
Fixes apache#8862 

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@DaanHoogland @dhslove
Merge release branch 4.19 to main
a88f395 
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (apache#9120)
  ui: fix create menu item access (apache#9104)
  server: honor listall param for listiso api (apache#9064)
  ui: add move to top/bottom for acl rules list (apache#9119)
  ui: fix columns for exportacls csv (apache#9118)
  ui: fix create network access in deploy vm wizard (apache#9117)
  UI: Add search filters (apache#9068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishesh92 vishesh92 vishesh92 approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes
@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland
@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees

No one assigned

Labels

component:UI

Projects

ACS Backlog
Status: Abhishek's Bugfix List
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shwstppr @weizhouapache @blueorangutan @vishesh92