Repository navigation
Export ACL List is missing some data #8862
Description
ISSUE TYPE
- Improvement Request
COMPONENT NAME
Improvement Request (UI, Functionality)
CLOUDSTACK VERSION
4.19
CONFIGURATION
N/A
OS / ENVIRONMENT
N/A
SUMMARY
Note: This ticket is broken down as requested from the origianl post, #8841
Export ACL List is missing some data
- For example, 'Ports' are not available in the exported CSV when exported.
- There may be others that are missing from the CSV output too.
- Exporting the full list as CV makes it very convenient to study, review the rules all at one go using excel.
- If it paired together with 'Import ACL from CSV' Allow users to import ACL from a CSV File #8858 , it would make ACL much easier to use all round.
STEPS TO REPRODUCE
N/A
N/A
EXPECTED RESULTS
To be able to manage ACL Rules more easily for large scale projects
ACTUAL RESULTS
Challenging to use ACL rules for large scale projects.
Activity
DaanHoogland commentedon Apr 11, 2024
@btzq , with "export", do you mean the output of a tool like cmk?
This seems a UI bug; if the first rule does not have start and end port these wont be in the exported CVS.
Note that the CVS export is a UI feature per se, so no API feature other than the response containing it or not.
This can be solved in the UI or in response (return -1?). I think UI makes more sense.
btzq commentedon Apr 12, 2024
@DaanHoogland when i meant 'Export', i meant the existing export function. Exporting via CMK is not required (For us at least).
My thoughts are that if a ACL rule doesnt have a start and end port, the columns should still be exported anyways with just empty value. Putting as -1 instead of empty value also makes sense.
Yes i think this is just a UI issue, the data is already there. So this is another low hanging fruit.
shwstppr commentedon May 22, 2024
@btzq I tried to check the csv for a rule without any ports and it shows
undefinedagainst port column. Is this not correct or am I missing something?btzq commentedon May 23, 2024
@shwstppr , what version of Cloudstack are you using? I am unable to export the 'Startport' and 'EndPort' in the xlsx.
Im using 4.19.0.0
This is my screenshot:
And this is how i exported it:
weizhouapache commentedon May 23, 2024
Yes, this is consistent with what Daan and me found. It is a ui bug
If the first rule does not have startport and endport (for example a icmp rule), the exported rules do not have startport and endport.
ui: fix columns for exportacls csv
shwstppr commentedon May 24, 2024
@btzq cc @weizhouapache I missed the fact that it needs to be the first rule without ports. I was able to reproduce and have create a fix in #9118
ui: fix columns for exportacls csv (#9118)
shwstppr commentedon May 28, 2024
Fixed with #9118
ui: fix columns for exportacls csv (apache#9118)