Repository navigation
UI: Add search filters - #9068
Merged
Merged
Conversation
Member
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9068 +/- ##
============================================
- Coverage 14.96% 4.30% -10.67%
============================================
Files 5373 363 -5010
Lines 469024 29293 -439731
Branches 58818 5115 -53703
============================================
- Hits 70197 1260 -68937
+ Misses 391056 27891 -363165
+ Partials 7771 142 -7629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
May 22, 2024
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
code looks good and filters show in qa (and work wherever I tried)
DaanHoogland
added a commit
that referenced
this pull request
May 28, 2024
* 4.19: engine-schema: add removed columne for cloud.user_data, fix delete op (#9120) ui: fix create menu item access (#9104) server: honor listall param for listiso api (#9064) ui: add move to top/bottom for acl rules list (#9119) ui: fix columns for exportacls csv (#9118) ui: fix create network access in deploy vm wizard (#9117) UI: Add search filters (#9068)
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
* 4.19: engine-schema: add removed columne for cloud.user_data, fix delete op (apache#9120) ui: fix create menu item access (apache#9104) server: honor listall param for listiso api (apache#9064) ui: add move to top/bottom for acl rules list (apache#9119) ui: fix columns for exportacls csv (apache#9118) ui: fix create network access in deploy vm wizard (apache#9117) UI: Add search filters (apache#9068)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7218
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?