Skip to content

ui: fix create menu item access - #9104

Merged
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:fix-ui-globalcreatemenuaccess
May 28, 2024
Merged

ui: fix create menu item access#9104
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:fix-ui-globalcreatemenuaccess

Conversation

@shwstppr

@shwstppr shwstppr commented May 22, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #9099

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: fix create menu item access
53916bd 
Fixes apache#9099

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
weizhouapache
weizhouapache approved these changes May 22, 2024
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@codecov

codecov Bot commented May 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (87e7c57) to head (53916bd).
Report is 4 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9104      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    10995    10987       -8     
============================================
  Files          5373     5373              
  Lines        469005   469024      +19     
  Branches      58953    58584     -369     
============================================
- Hits          70198    70185      -13     
- Misses       391036   391069      +33     
+ Partials       7771     7770       -1
Flag Coverage Δ
uitests 4.31% <ø> (ø)
unittests 15.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwstppr

shwstppr commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

UI build failed: ✖️
(SL-JID-344)

@shwstppr

shwstppr commented May 24, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

UI build failed: ✖️
(SL-JID-348)

@weizhouapache weizhouapache added this to the 4.19.1.0 milestone May 24, 2024
@weizhouapache

weizhouapache commented May 24, 2024

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

blueorangutan commented May 24, 2024

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr

shwstppr commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

blueorangutan commented May 27, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 27, 2024

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9104 (QA-JID-357)

DaanHoogland
DaanHoogland approved these changes May 28, 2024
View reviewed changes

@DaanHoogland DaanHoogland left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and does what it says on the tin (in qa)
one sugestion for improvement is that if the create menu is empty the button should not be there:
image

Ad: this ^ is an empty menu

@shwstppr

shwstppr commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

@DaanHoogland I'll create a separate PR for hiding Create button when no menu items present. It may require some additional changes in menu structure

@DaanHoogland
DaanHoogland merged commit c36a3b8 into apache:4.19 May 28, 2024
@DaanHoogland
DaanHoogland deleted the fix-ui-globalcreatemenuaccess branch May 28, 2024 07:27
@shwstppr shwstppr mentioned this pull request May 28, 2024
Closed
DaanHoogland added a commit that referenced this pull request May 28, 2024
@DaanHoogland
Merge release branch 4.19 to main
f1c3d2c 
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (#9120)
  ui: fix create menu item access (#9104)
  server: honor listall param for listiso api (#9064)
  ui: add move to top/bottom for acl rules list (#9119)
  ui: fix columns for exportacls csv (#9118)
  ui: fix create network access in deploy vm wizard (#9117)
  UI: Add search filters (#9068)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@shwstppr @dhslove
ui: fix create menu item access (apache#9104)
e82f18a 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@DaanHoogland @dhslove
Merge release branch 4.19 to main
a88f395 
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (apache#9120)
  ui: fix create menu item access (apache#9104)
  server: honor listall param for listiso api (apache#9064)
  ui: add move to top/bottom for acl rules list (apache#9119)
  ui: fix columns for exportacls csv (apache#9118)
  ui: fix create network access in deploy vm wizard (apache#9117)
  UI: Add search filters (apache#9068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes
@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees

No one assigned

Labels

component:UI

Projects

ACS Backlog
Status: Abhishek's Bugfix List
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shwstppr @blueorangutan @weizhouapache @DaanHoogland