Repository navigation
Conversation
The chart is published to oci://quay.io/ai-openshell/charts/openshell after the repository transfer, and Helm derives the OCI artifact name from the chart name. Rename the chart from helm-chart to openshell and point the install instructions at the new location. values.yaml sets nameOverride to openshell, so resource names and selectors do not depend on the chart name. Only the helm.sh/chart label changes, which rolls the gateway pods once through the config checksum. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
3 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helm derives the OCI artifact name from the chart name. The chart is published to
oci://quay.io/ai-openshell/charts/openshellafter the repository transfer, so this renames it fromhelm-charttoopenshelland points the install instructions at the new location.Draft until the transfer is done. It merges together with #5808, which pushes charts to Quay and reads the chart name from
Chart.yaml. Without this rename, #5808 would push tocharts/helm-chart, which does not exist on Quay. With this rename but without #5808, the current release action looks uphelm-charton GHCR and pushes the renamed chart tooci://ghcr.io/nvidia/openshell/openshell.Stacked on #5822.
Related Issue
Refs #4554
Changes
deploy/helm/openshell/Chart.yaml:name: openshell.ci/values-namespace-admin.yaml:oci://quay.io/ai-openshell/charts/openshell.tests/tmachine/config.nix: the locally packaged chart is nowopenshell-0.0.0.tgz.Upgrade safety
values.yamlsetsnameOverride: openshell, soopenshell.nameandopenshell.fullnamedo not depend on.Chart.Name. A rendered diff ofhelm templatebefore and after, for the defaults andci/values-supervisor.yaml, changes only:helm.sh/chartlabel (helm-chart-0.0.0toopenshell-0.0.0, on 19 and 24 resources),# Source:comments,Resource names, selectors and
app.kubernetes.io/namedo not change, sohelm upgradeof a release installed fromhelm-chartupdates the same objects. The checksum change rolls the gateway pods once, which the image change in #5822 does anyway.Release Notes
The OpenShell Helm chart is published as
oci://quay.io/ai-openshell/charts/openshell. Existing releases installed fromoci://ghcr.io/nvidia/openshell/helm-chartupgrade in place.Testing
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
helm lintwith the defaults and everyci/values-*.yaml.helm unittest: 499/499 and 7/7.test-split-ownership.sh,test-gateway-resource-coherence.shandtest-supervisor-pool-scaling.sh.The README matches
helm-docs1.14.2 output.helm package deploy/helm/openshellwritesopenshell-0.0.0.tgz, the pathtests/tmachine/config.nixnow uses.Not verified: no real
helm upgradefrom ahelm-chartrelease on a cluster, and no tmachine k3s run.Checklist