Repository navigation
Conversation
Point the Docker Compose gateway image, the sample Docker gateway.toml and the k3s HelmChart manifest at quay.io/ai-openshell, where released images are published after the repository transfer. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
3 of 6 tasks
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. configuration — No explicit risk acceptance foundThe shipped Compose gateway image and Docker sandbox_runtime_image/supervisor_image settings switch from ghcr.io/nvidia/openshell/* to quay.io/ai-openshell/* without fallback.
Review details
Advisory review; publication gates are unchanged. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points the Docker Compose gateway image, the sample Docker
gateway.tomland the k3s HelmChart manifest atquay.io/ai-openshell, where released images are published after the repository transfer.Draft until the transfer is done. It merges after the transfer and after releases publish to Quay, before the first release cut from the new repository. Stacked on #5823.
Related Issue
Refs #4554
Changes
deploy/docker/docker-compose.yml:quay.io/ai-openshell/gateway:${IMAGE_TAG:-latest}.deploy/docker/gateway.toml:sandbox_runtime_imageandsupervisor_imageusequay.io/ai-openshell/{sandbox,supervisor}:latest.deploy/kube/manifests/openshell-helmchart.yaml:registry: quay.ioand repositoriesai-openshell/{gateway,supervisor}, matching the chart split in chore(images): default released images to quay.io/ai-openshell #5822.The Compose file and
gateway.tomldefault to:latest, so they need a floatinglatesttag on Quay.Testing
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
docker compose configresolves both services toquay.io/ai-openshell/gateway:<tag>.taplo check deploy/docker/gateway.toml.The manifest's embedded
valuesContentparses to the new registry and repositories.Not verified: no
docker compose up, because Quay has no images yet.Checklist