Repository navigation
Conversation
The release-helm-oci action now logs in to Quay with the org's quay-login action and pushes the gateway and workspace charts to oci://quay.io/ai-openshell/charts. The gateway chart is published as charts/openshell, which needs the chart rename from helm-chart. The duplicate-version guard and dev SHA-pinned chart are unchanged. Refs #4554 Signed-off-by: Simon Scatton <sscatton@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-5808.docs.buildwithfern.com/openshell |
3 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
release-helm-ociaction now pushes the gateway and workspace charts tooci://quay.io/ai-openshell/chartsinstead ofoci://ghcr.io/nvidia/openshell, logging in with the org'squay-loginaction.Stacked on the image promotion PR. Draft for the same reason: it can't run until the repository is in
ai-openshelland thereleaseenvironment exists.Merge this together with the chart rename from
helm-charttoopenshell. Helm pushes tocharts/<Chart.yaml name>, so until the rename lands the gateway chart would publish tocharts/helm-chart.Related Issue
Refs #4554
Changes
ai-openshell+openshell_release(clients: helm) after installing Helm. The GHCR login is gone.oci://quay.io/ai-openshell/charts, so they publish ascharts/openshellandcharts/openshell-workspace.Chart.yamlfiles rather than hard-coding them, so it follows the rename. Public versions are still never overwritten.0.0.0-dev.<sha>chart. Its images exist on Quay because the previous PR promotes:<sha>.release-helmjobs in Release Dev and Publish Release run inenvironment: releasewithid-token: write.packages: writeis removed.Testing
Not-found check:
helm show chart oci://quay.io/ai-openshell/charts/openshell --version 0.0.1against the empty Quay repo returnsquay.io/ai-openshell/charts/openshell:0.0.1: not found, which matches the guard's pattern.Name extraction: the
sedreadshelm-chartandopenshell-workspacefrom today's charts.Lints:
actionlintpasses andzizmorreports no findings on the action.Not verified: the Quay login and push. Both need the moved repository.
Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Checklist