Skip to content

chore(images): default released images to quay.io/ai-openshell - #5822

Draft
SDAChess wants to merge 1 commit into
mainfrom
chore/4554-quay-image-defaults/SDAChess
Draft

SDAChess wants to merge 1 commit into
mainfrom
chore/4554-quay-image-defaults/SDAChess

Conversation

@SDAChess

Copy link
Copy Markdown
Contributor

Summary

Released gateway, supervisor and sandbox images move from ghcr.io/nvidia/openshell to quay.io/ai-openshell with the repository transfer. This points the gateway's built-in image defaults and the Helm chart's image values at Quay.

Draft until the transfer is done. It merges after the transfer, once releases publish to Quay (#5807), and before the first release cut from the new repository. Quay has no releases yet, and releases up to v0.1.10-pre.3 are not copied there, so merging early would point main at images that do not exist.

Related Issue

Refs #4554

Changes

  • crates/openshell-core: DEFAULT_SUPERVISOR_IMAGE_REPO and DEFAULT_SANDBOX_RUNTIME_IMAGE_REPO become quay.io/ai-openshell/{supervisor,sandbox}.
  • Helm values.yaml: global.image.registry: quay.io and repositories ai-openshell/{gateway,sandbox,supervisor}, replacing ghcr.io/nvidia with openshell/<name>. The registry is now only the host, so a path-preserving pull-through mirror needs only global.image.registry.
  • Helm _helpers.tpl: the two strings that stand for the gateway's built-in images change in the same commit as the Rust constants. The chart omits sandbox_runtime_image from gateway.toml only when it equals the gateway's own default, so both sides have to move together.
  • Tests that assert on the defaults: openshell-core config, the Docker and Podman driver tests, the openshell-server config example, and the Helm unit tests. The regenerated chart README.

Test fixtures that use image names only as sample strings (openshell-ocsf tests, the VM driver's registry-host test) are unchanged.

Release Notes

OpenShell images are published to quay.io/ai-openshell. The gateway's default supervisor and sandbox runtime images and the Helm chart's image values now point there. If you set global.image.registry to a mirror, the chart now pulls <mirror>/ai-openshell/<name> instead of <mirror>/openshell/<name>.

Testing

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (if applicable)

  • E2E tests added/updated (if applicable)

  • helm lint and helm template with the defaults and every ci/values-*.yaml.

  • helm unittest: 499/499 for deploy/helm/openshell, 7/7 for deploy/helm/openshell-workspace.

  • deploy/helm/test-split-ownership.sh, test-gateway-config-parser.sh (the rendered TOML passes the Rust loader), test-gateway-resource-coherence.sh, test-supervisor-pool-scaling.sh and tasks/scripts/test-e2e-image-overrides.sh.

  • cargo test for openshell-core config, the openshell-driver-docker supervisor image tests, the openshell-driver-podman pull policy test and openshell-server config_file.

  • Rendered helm template before and after, for the defaults and for ci/values-supervisor.yaml: only the image references and the gateway config checksum change, apart from the randomly generated key-encryption key.

Not verified: no E2E run against Quay, which has no images yet. The full workspace cargo test and clippy were not run.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Released gateway, supervisor and sandbox images move from
ghcr.io/nvidia/openshell to quay.io/ai-openshell with the repository
transfer. Point the gateway's built-in image defaults and the Helm
chart's image values at Quay.

The chart now splits the reference as registry quay.io and repository
ai-openshell/<name>, so a path-preserving mirror only needs
global.image.registry. The chart helpers that mirror the gateway's
built-in defaults change in the same commit as the Rust constants, so
Helm keeps omitting sandbox_runtime_image only when it matches what the
gateway would pick on its own.

Refs #4554

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@github-actions

Copy link
Copy Markdown

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. helm — No explicit risk acceptance found

global.image.registry=&lt;mirror&gt; now resolves gateway, supervisor, and sandbox runtime images under &lt;mirror&gt;/ai-openshell/ instead of &lt;mirror&gt;/openshell/.

  • Impact: Existing air-gapped deployments using the documented registry-only override encounter image-pull failures when their mirrors retain the previously supported repository paths.
  • Action: Preserve existing mirror paths for v0.1.10; document setting gateway.image.repository=openshell/gateway, supervisor.image.repository=openshell/supervisor, and sandboxRuntime.image.repository=openshell/sandbox as a workaround.
  • PR: chore(images): default released images to quay.io/ai-openshell #5822
Review details
  • Execution: complete
  • Candidate: PR #5822 (c56c8278f8244238442ff99f87266518109570d5)
  • Baseline: 00390c8acb1f0d0055400124e957e85efa0c5106 (00390c8acb1f0d0055400124e957e85efa0c5106)
  • Reviewed: rust-sdk, python-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant