Skip to content

fix(appstore): ExApp removal, install and status updates - #66565

Open
oleksandr-nc wants to merge 2 commits into
masterfrom
fix/appstore-exapps
Open

oleksandr-nc wants to merge 2 commits into
masterfrom
fix/appstore-exapps

Conversation

@oleksandr-nc

Copy link
Copy Markdown
Contributor

Fixes #66119

Several ExApp actions in the app store did not work:

  • Remove only disabled an ExApp, so it stayed installed and its container kept running.
  • Deploy and enable failed in the browser before sending anything when only one deploy daemon exists.
  • Locally registered ExApps (not from the App Store) had no buttons at all, because their missing update broke the update label.
  • After an install or update, the status of the deploy was not polled, a page opened during a deploy never noticed when it finished, and a removed ExApp was polled forever.
  • An ExApp update did not ask for the password, so after a while AppAPI refused it, and the Update button disappeared after any failed update.
  • AppAPI's error messages were not shown, an ExApp whose initialization failed could not be removed, and "Limit to groups" was offered for ExApps although it does nothing for them.
  • The first click on an action could fail with "App with id ... not found", because the actions looked up the store in whichever Pinia was active (the user status menu has its own).

Changes

  • Remove uninstalls the ExApp through AppAPI and keeps its data.
  • The single-daemon install uses that daemon and waits for the request.
  • ExApps without an update get their buttons, Remove is hidden while an ExApp is being deployed, as in AppAPI's own check, and an ExApp whose initialization failed can be removed.
  • The status is polled after an install or update and when a page is opened during a deploy; polling stops when the deploy is done, when the ExApp is gone, or on an error, and the row shows the right buttons afterwards.
  • ExApp update asks for the password like the other ExApp actions, keeps its button and the update count when it fails, and AppAPI's messages are shown for failed ExApp actions.
  • The update count only drops for apps that had an update, removed ExApps that are not in the App Store leave the list, and "Limit to groups" is not offered for ExApps.
  • Actions and dialogs use the app store's own Pinia.

This also covers the single-daemon fix of #65703.

oleksandr-nc and others added 2 commits November 13, 2026 14:15
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
Co-authored-by: Stavros Kois <s.kois@outlook.com>
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App Store ExApp 'Deploy and enable' fails with one deploy daemon (Nextcloud 35.0.2)

1 participant