Repository navigation
Conversation
When exactly one docker daemon is registered, enableApp read the daemon from the ref itself instead of its value, so enableExApp got undefined and failed in the browser before sending any request. The call was also not awaited, so the error was swallowed and the button only flickered. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Stavros Kois <s.kois@outlook.com>
|
@stavros-k Thanks for fixing this. The same function has a second problem that affects Kubernetes daemons, and it might make sense to fix it here since it's a few lines further down.
server/apps/appstore/src/store/exApps.ts Line 257 in 5e2ea64 A HaRP daemon registered with The backend doesn't need a change. Suggested change: dockerDaemons.value = data.daemons.filter((daemon: IDeployDaemon) => ['docker-install', 'kubernetes-install'].includes(daemon.accepts_deploy_id))
The filter is identical on stable34 and stable35, and HaRP's Kubernetes backend is supported from 34 on, so backports to both would be worth it. Assisted-by: ClaudeCode:claude-opus-5-5 |
|
Feel free to take over the PR if you think the fix should be in this PR. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Thank you for the fix and the test. The app store had more ExApp bugs in the same store (Remove only disabled ExApps, no status polling after an install, no password confirmation for updates), so we fixed them together in #66565, which includes your change and credits you as co-author. |
Summary
When exactly one docker daemon is registered,
enableAppread the daemonfrom the ref itself instead of its value, so
enableExAppgotundefinedand failed in the browser before sending any request. The call was also
not awaited, so the error was swallowed and the button only flickered.
Checklist
3. to review, feature component)stable32)AI (if applicable)