Repository navigation
fix(appstore): offer only HaRP daemons for ExApp installs - #66566
Open
oleksandr-nc wants to merge 1 commit into
Open
oleksandr-nc wants to merge 1 commit into
oleksandr-nc wants to merge 1 commit into
Conversation
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
oleksandr-nc
requested review from
kristian-zendato and
pringelmann
and removed request for
a team
November 13, 2026 17:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy daemon dialog for ExApp installs offered every Docker daemon, also Docker Socket Proxy daemons, which AppAPI refuses on Nextcloud 36 (nextcloud/app_api#1209), and manual install daemons, which cannot deploy anything. Kubernetes daemons were not offered at all, although AppAPI installs ExApps on them.
The dialog now offers the HaRP daemons, Docker and Kubernetes. It needs nextcloud/app_api#1209 and nextcloud/app_api#1210 (Kubernetes resources removed on uninstall), so it is for master only. Based on #66565; merge after it.