Repository navigation
Keep the guardrail alert visible on the carb and meal edit screens - #786
Merged
Merged
Conversation
Tapping Update while the carb field is focused ran the guardrail check and then the form validation right after it. The guardrail alert reset the field to 0, so the validation replaced it with the empty-amount alert, or for a Trio meal with fat or protein, with the confirmation showing 0 g carbs. The validation now skips when an alert is already showing.
marionbarker
approved these changes
Oct 23, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by test (for Loop) and code review (similarity between Loop and Trio changes).
snickerdoodleparent
pushed a commit
to snickerdoodle-co/LoopFollow
that referenced
this pull request
Nov 4, 2026
Treatment details from a chart pill (loopandlearn#781), CGM sensor states from Nightscout notes (loopandlearn#763), the full predictive low window (loopandlearn#751), app exit reasons and memory use logged (loopandlearn#788), the guardrail alert on the carb and meal edit screens (loopandlearn#786), Loop's automatic boluses as Auto Bolus (loopandlearn#787), Loop IOB and COB on failed loops and the pump battery held (loopandlearn#784); loopandlearn#734 and loopandlearn#771 were in already. Kept from this branch: the time first in the bolus, carb and SMB pills (now "Auto Bolus" for Loop), the weekend profile's own band color and its Treatments entry (moved into Treatment.historyEntries), the override's scheduled end, the alarm title override, and the Live Activity history. The carb double-tap gives way to loopandlearn#781's linked pills, which open any treatment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LgnnHLJbhxmQaEjQNYR5VZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a value over the max carbs, fat or protein setting is entered on the Loop carb edit or Trio meal edit screen and Update is tapped, the guardrail alert with the minimum and maximum now stays up until dismissed. The follow-up validation is skipped while an alert is showing, so it can't replace the guardrail message with the empty-amount alert or with a confirmation showing 0 g carbs.