Repository navigation
Open treatment details from a chart pill - #781
Merged
Merged
Conversation
A single tap on a chart mark shows its pill as before. If the mark is in the Treatments list (carbs, boluses, SMBs, overrides, temp targets) the pill shows a chevron, and tapping the pill opens the treatment's details. Double-tap only zooms. The chart and the Treatments list build their entries with the same Treatment.historyEntries, so the pill opens the entry from the Nightscout treatment that drew the mark.
bjorkert
added a commit
to bjorkert/LoopFollow
that referenced
this pull request
Oct 17, 2026
# Conflicts: # LoopFollow/Controllers/Nightscout/Treatments/Overrides.swift # LoopFollow/Helpers/DataStructs.swift
Collaborator
Test✅ successful test Test DetailsUse 2 test phones, one observing a Loop URL and one observing a Trio URL.
|
kristinkand
added a commit
to kristinkand/LoopFollow
that referenced
this pull request
Oct 25, 2026
… own start date The merge brought upstream's loopandlearn#763 a second time (this branch had it already as 2d9a42c), so BGDisplayView declared cgmSensorState twice. The override pills' details (loopandlearn#781) use upstream's startDate, which this branch computes per entry: the entry's own start now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LgnnHLJbhxmQaEjQNYR5VZ (cherry picked from commit d25a62f)
snickerdoodleparent
pushed a commit
to snickerdoodle-co/LoopFollow
that referenced
this pull request
Nov 4, 2026
Treatment details from a chart pill (loopandlearn#781), CGM sensor states from Nightscout notes (loopandlearn#763), the full predictive low window (loopandlearn#751), app exit reasons and memory use logged (loopandlearn#788), the guardrail alert on the carb and meal edit screens (loopandlearn#786), Loop's automatic boluses as Auto Bolus (loopandlearn#787), Loop IOB and COB on failed loops and the pump battery held (loopandlearn#784); loopandlearn#734 and loopandlearn#771 were in already. Kept from this branch: the time first in the bolus, carb and SMB pills (now "Auto Bolus" for Loop), the weekend profile's own band color and its Treatments entry (moved into Treatment.historyEntries), the override's scheduled end, the alarm title override, and the Live Activity history. The carb double-tap gives way to loopandlearn#781's linked pills, which open any treatment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LgnnHLJbhxmQaEjQNYR5VZ
snickerdoodleparent
pushed a commit
to snickerdoodle-co/LoopFollow
that referenced
this pull request
Nov 4, 2026
… own start date The merge brought upstream's loopandlearn#763 a second time (this branch had it already as 2d9a42c), so BGDisplayView declared cgmSensorState twice. The override pills' details (loopandlearn#781) use upstream's startDate, which this branch computes per entry: the entry's own start now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LgnnHLJbhxmQaEjQNYR5VZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a mark on the main chart shows its pill. If the mark is in the Treatments list (carbs, boluses, SMBs, overrides and temp targets) the pill has a chevron, and tapping the pill opens the treatment's details. Double-tap only zooms, so a missed double-tap can't open the wrong entry.
The chart and the Treatments list build their entries with the same code, so the pill opens the entry for the exact Nightscout treatment that drew the mark. Replaces #743.