Repository navigation
Show Loop IOB and COB on failed loops and hold the pump battery - #784
Merged
Merged
Conversation
Loop uploads IOB and COB in records where the loop failed, so they are shown for those records too. The pump battery row keeps the last reading for up to an hour when a record leaves it out. Co-authored-by: Phil A <76601115+MtlPhil@users.noreply.github.com>
marionbarker
approved these changes
Oct 23, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by code review and test build.
snickerdoodleparent
pushed a commit
to snickerdoodle-co/LoopFollow
that referenced
this pull request
Nov 4, 2026
Treatment details from a chart pill (loopandlearn#781), CGM sensor states from Nightscout notes (loopandlearn#763), the full predictive low window (loopandlearn#751), app exit reasons and memory use logged (loopandlearn#788), the guardrail alert on the carb and meal edit screens (loopandlearn#786), Loop's automatic boluses as Auto Bolus (loopandlearn#787), Loop IOB and COB on failed loops and the pump battery held (loopandlearn#784); loopandlearn#734 and loopandlearn#771 were in already. Kept from this branch: the time first in the bolus, carb and SMB pills (now "Auto Bolus" for Loop), the weekend profile's own band color and its Treatments entry (moved into Treatment.historyEntries), the override's scheduled end, the alarm title override, and the Live Activity history. The carb double-tap gives way to loopandlearn#781's linked pills, which open any treatment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LgnnHLJbhxmQaEjQNYR5VZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #780 by @MtlPhil and is based on his work there.
I measured what the info table shows minute by minute, using a week of device status Nightscout sites Loop, Trio or iAPS. With Loop, IOB and COB went blank whenever the newest record had a failureReason, because those rows were only read for successful loops. Loop still uploads IOB and COB in those records, and the IOB timestamp is at most about five minutes older than the record. That was about 1 % of the time across the Loop sites and up to ten hours a week on some of them. With Trio, IOB, COB, TDD, autosens and the phone battery never went blank. The only Trio row that did was the pump battery, missing 0.6 to 3.7 % of the time.
IOB and COB are now read before the failure check, so the info rows, alarms and Live Activity get the values from failed loops too. Recommended bolus is still only taken from successful loops. The pump battery row keeps the last reading for up to an hour when a record leaves it out. In the same data that covered 96 % of the blank pump battery time, and the held value never differed from the next real one.