Repository navigation
Ruby: Lower access path limit to 1 for OrmTracking - #15866
Merged
Merged
Conversation
hvitved
force-pushed
the
ruby/orm-tracking-ap-limit
branch
2 times, most recently
from
March 11, 2024 11:59
31b2c81 to
9588ca6
Compare
hvitved
changed the title
OrmTrackingOrmTracking
hvitved
force-pushed
the
ruby/orm-tracking-ap-limit
branch
from
March 12, 2024 13:58
9588ca6 to
695e728
Compare
hvitved
marked this pull request as ready for review
March 13, 2024 09:39
This was referenced Mar 13, 2024
hmac
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data flow loop used in
OrmTrackingis known to be quite slow/infeasible on some DBs, so this PR reduces the access path limit from 5 to 1. This is the same access path limit as used in type tracking, but flow precision is generally much better (call context sensitivity, full support for flow summaries, full support for captured variables, etc.).