Repository navigation
Conversation
hmac
force-pushed
the
simplify-orm-tracking
branch
from
March 8, 2024 12:54
fbca293 to
530ae00
Compare
hmac
marked this pull request as ready for review
March 11, 2024 08:49
Contributor
|
I also have a WIP branch for this, and I would like to investigate a bit further until we decide on the approach to take. |
Contributor
|
I think we should go with #15866, as it resolves the performance issue that we saw. Also, DCA only reports 2 lost results on that PR, while DCA on this PR reports 3 lost results and 47 new (most likely FP) results. |
Contributor
Author
|
Closed in favour of #15866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix the performance issues on certain databases, whilst not losing too many results (and gaining some new ones).