Repository navigation
Data flow: Add ConfigSig::accessPathLimit - #15867
Merged
Merged
Conversation
atorralba
previously approved these changes
Mar 12, 2024
atorralba
left a comment
atorralba
left a comment
Contributor
There was a problem hiding this comment.
As I understand it, we already had a default access path limit of 5, so this shouldn't cause any changes in results.
Contributor
Author
Correct, no result changes are expected. |
aschackmull
reviewed
Mar 12, 2024
aschackmull
reviewed
Mar 12, 2024
aschackmull
reviewed
Mar 12, 2024
aschackmull
reviewed
Mar 12, 2024
aschackmull
reviewed
Mar 12, 2024
aschackmull
left a comment
aschackmull
left a comment
Contributor
There was a problem hiding this comment.
I think you missed the reference to accessPathLimit in partial flow.
hvitved
force-pushed
the
dataflow/ap-limit
branch
2 times, most recently
from
March 12, 2024 11:03
5888236 to
1161ca2
Compare
aschackmull
reviewed
Mar 12, 2024
hvitved
force-pushed
the
dataflow/ap-limit
branch
from
March 12, 2024 12:35
1161ca2 to
d7790fa
Compare
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to control the access path limit on a per-configuration basis. Needed for #15866.