Skip to content

Patch for CRT error where AuxDets can't be found - #240

Merged
pgreen135 merged 6 commits into
release/SBN2021Cfrom
bugfix/hlay_crt_channels
Dec 15, 2021
Merged

pgreen135 merged 6 commits into
release/SBN2021Cfrom
bugfix/hlay_crt_channels

Conversation

@henrylay97

Copy link
Copy Markdown
Member

Very intermittent error found by @jzennamo. Also thanks to @marcodeltutto and @wesketchum for help with debugging.

---- ChannelMap BEGIN
  Can't find AuxDet for position (132.794,-376.746,-8.4112)
  The above exception was thrown while processing module GenericCRT/genericcrt run: 1 subRun: 0 event: 84
---- ChannelMap END

This error is being thrown in the ChannelMapAlg but this PR overrides the relevant functions in sbndcode's ChannelMapSBNDAlg.

Instead of throwing an exception the same error message is now outputted as a debugging message and the function returns UINT_MAX as the channel ID.

A catch is added at the detsim stage and in a detsim analysis module to skip channels with the ID UINT_MAX.

The underlying bug is worth investigating further and @ilepetic can probably comment further.

Due the rare nature of this bug I haven't been able to consistently reproduce it to test these changes on, however I have made some tests of the detsim stage where I forcibly return UINT_MAX and the catch works fine.

@marcodeltutto marcodeltutto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much @hlay! I just have a couple of comments.

Could you also remove this exception here and add a debug message as you did in ChannelMapSBNDAlg? Otherwise, if someone uses AuxDetGeometryCore that will throw an exception.

Comment thread sbndcode/CRT/CRTDetSim_module.cc Resolved
@henrylay97
henrylay97 force-pushed the bugfix/hlay_crt_channels branch from 5a2c00d to 1762407 Compare December 14, 2021 11:36
@henrylay97
henrylay97 force-pushed the bugfix/hlay_crt_channels branch from 1762407 to 247f43d Compare December 14, 2021 11:38
@henrylay97

Copy link
Copy Markdown
Member Author

Thanks @marcodeltutto, all great suggestions. I've followed up in the above commits 👍

@pgreen135

Copy link
Copy Markdown
Member

trigger build

1 similar comment
@pgreen135

Copy link
Copy Markdown
Member

trigger build

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@marcodeltutto marcodeltutto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@pgreen135
pgreen135 merged commit 8f2309a into release/SBN2021C Dec 15, 2021
@henrylay97 henrylay97 mentioned this pull request Jan 11, 2022
@pgreen135
pgreen135 deleted the bugfix/hlay_crt_channels branch April 15, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants