Repository navigation
Patch for CRT error where AuxDets can't be found - #240
Conversation
Updating develop with changes in SBN2021C branch
168845b to
22359a2
Compare
5a2c00d to
1762407
Compare
1762407 to
247f43d
Compare
|
Thanks @marcodeltutto, all great suggestions. I've followed up in the above commits 👍 |
|
trigger build |
1 similar comment
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Very intermittent error found by @jzennamo. Also thanks to @marcodeltutto and @wesketchum for help with debugging.
This error is being thrown in the ChannelMapAlg but this PR overrides the relevant functions in sbndcode's ChannelMapSBNDAlg.
Instead of throwing an exception the same error message is now outputted as a debugging message and the function returns
UINT_MAXas the channel ID.A catch is added at the detsim stage and in a detsim analysis module to skip channels with the ID
UINT_MAX.The underlying bug is worth investigating further and @ilepetic can probably comment further.
Due the rare nature of this bug I haven't been able to consistently reproduce it to test these changes on, however I have made some tests of the detsim stage where I forcibly return
UINT_MAXand the catch works fine.