Repository navigation
CAF fix merge into production branch - #225
miquelnebot wants to merge 62 commits into
Conversation
…lls in SRHeader with one entry per event. More ideal is an entry per subrun.
… and CAFmaker. Output comes in same way as it did previously
…ncode into mdeltutt_fluxreader_boone
sbncode v09_40_00 for larsoft v09_40_00 using: sbnanaobj v09_17_08
Greenlee pid update
…lls in SRHeader with one entry per event. More ideal is an entry per subrun.
… and CAFmaker. Output comes in same way as it did previously
… and data label and using whichever one works.
…gCAFs_take2 feature/jzettle_pot_accounting_cafs_take2
sbncode v09_41_00 for larsoft v09_41_00 using: larsoft v09_41_00 sbnobj v09_13_01 sbnanaobj v09_17_09
|
I can't comment on whether we/need want all of this. I can't see any glaring reasons why not! My only comment is on the version numbers & dependencies to make sure they are reverted back to the ones we want in the production branch. |
|
Do we need the FluxReader stuff? Isn't that independent of CAF making? Otherwise, I guess we want all this (some of it I know we definitely do, other parts seem fine, and we probably want to have the CAFs produced be as close as possible to the state in develop). I think the volume of changes here tells us something about the timing of the production branches i.e. that we should probably have chosen a more recent branch-off point for the release to be used for CAF making. |
|
This was substituted by #226 with only the necessary for the production. |
This is meant to include CAF fix needed for the production patch, but also some other later developments (BNB retriever, flux reader, fcl changes...)
Could people involved confirm what is needed/wanted for the production patch? or it's just #223 ?