Skip to content

CAF fix merge into production branch - #225

Closed
miquelnebot wants to merge 62 commits into
release/SBN2021Cfrom
develop
Closed

miquelnebot wants to merge 62 commits into
release/SBN2021Cfrom
develop

Conversation

@miquelnebot

Copy link
Copy Markdown
Contributor

This is meant to include CAF fix needed for the production patch, but also some other later developments (BNB retriever, flux reader, fcl changes...)
Could people involved confirm what is needed/wanted for the production patch? or it's just #223 ?

marcodeltutto and others added 30 commits October 12, 2021 08:20
…lls in SRHeader with one entry per event. More ideal is an entry per subrun.
… and CAFmaker. Output comes in same way as it did previously
miquelnebot and others added 16 commits December 17, 2021 05:55
sbncode v09_40_00
for larsoft v09_40_00
using:
sbnanaobj           v09_17_08
…lls in SRHeader with one entry per event. More ideal is an entry per subrun.
… and CAFmaker. Output comes in same way as it did previously
… and data label and using whichever one works.
…gCAFs_take2

feature/jzettle_pot_accounting_cafs_take2
sbncode v09_41_00
for larsoft v09_41_00
using:
larsoft             v09_41_00
sbnobj              v09_13_01
sbnanaobj           v09_17_09
@miquelnebot

Copy link
Copy Markdown
Contributor Author

Also, what's the relation with the issues
#219
#220
#221

@henrylay97

Copy link
Copy Markdown
Member

I can't comment on whether we/need want all of this. I can't see any glaring reasons why not! My only comment is on the version numbers & dependencies to make sure they are reverted back to the ones we want in the production branch.

@cjbacchus

Copy link
Copy Markdown
Contributor

Also, what's the relation with the issues #219 #220 #221

These are a longer-term plan. Nothing in any of these commits implements any of this, but nor do we need to right now.

@cjbacchus

Copy link
Copy Markdown
Contributor

Do we need the FluxReader stuff? Isn't that independent of CAF making?

Otherwise, I guess we want all this (some of it I know we definitely do, other parts seem fine, and we probably want to have the CAFs produced be as close as possible to the state in develop).

I think the volume of changes here tells us something about the timing of the production branches i.e. that we should probably have chosen a more recent branch-off point for the release to be used for CAF making.

@miquelnebot miquelnebot mentioned this pull request Jan 13, 2022
@miquelnebot

Copy link
Copy Markdown
Contributor Author

This was substituted by #226 with only the necessary for the production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants