Skip to content

feature/jzettle_pot_accounting_cafs_take2 - #224

Merged
miquelnebot merged 7 commits into
developfrom
feature/jzettle_POTAccountingCAFs_take2
Dec 22, 2021
Merged

miquelnebot merged 7 commits into
developfrom
feature/jzettle_POTAccountingCAFs_take2

Conversation

@cjbacchus

Copy link
Copy Markdown
Contributor

This was initially merged in #211 and reverted in #218

This PR adds one additional commit to the end that avoids dependency on fIsRealData by just trying both labels.

Depends on SBNSoftware/sbnanaobj#41

@jzettle

jzettle commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Thanks @cjbackhouse. Did you start with the latest version of the original branch? 05c2859. This looks based on an older version before some of the other comments were addressed

@cjbacchus

Copy link
Copy Markdown
Contributor Author

I cherry-picked ce4b924 b6aa24b 7c563da 051a9e2 05c2859 so I think I should have everything?

@cjbacchus

Copy link
Copy Markdown
Contributor Author

Hang on. Maybe it didn't all take...

@cjbacchus
cjbacchus force-pushed the feature/jzettle_POTAccountingCAFs_take2 branch from d85756f to 58bab13 Compare December 21, 2021 18:20
… and data label and using whichever one works.
@cjbacchus

Copy link
Copy Markdown
Contributor Author

OK, does this look right now?

@jzettle

jzettle commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

It does thanks. This looks good to me

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbnanaobj#41

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

@cjbackhouse @jzettle CI fails here while SBNSoftware/sbnanaobj#41 succeed. Could you check it?

@jzettle

jzettle commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

I think @cjbackhouse should comment more but I think now he has added an abort if it doesn't see the POT information (I'm not experienced enough in art-based things to understand if this is a fcl label or the product itself is empty). I'm not sure what CI does but maybe it runs afoul of that new requirement I see the message Found neither data POT info under 'bnbinfo' nor MC POT info under 'generator' which I think implies it didn't find what it needs to continue.

@jzettle

jzettle commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Although looking at this again and maybe I'm getting my negatives wrong but I see it looks for if(!fParams.BNBPOTDataLabel().empty() || !fParams.GenLabel().empty()). Does this actually mean it aborts if something isn't empty or it does see something? @cjbackhouse were you able to make a caf file with this I feel like I'm misunderstanding something?

@cjbacchus

Copy link
Copy Markdown
Contributor Author

You should be able to successfully make a CAF from a singles file if you set both the BNBPOTDataLabel and GenLabel to the empty string, indicating that you aren't expecting to find any POT information in the file.
Do you know what the value of StrictMode is in your config? I should have probably allowed things to work regardless if strict mode is false.

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build SBNSoftware/sbnanaobj#41

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot
miquelnebot merged commit 12decc1 into develop Dec 22, 2021
@jzettle

jzettle commented Dec 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @cjbackhouse for your help in getting this all corrected and implemented!

@cjbacchus
cjbacchus deleted the feature/jzettle_POTAccountingCAFs_take2 branch August 30, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants