Repository navigation
feature/jzettle_pot_accounting_cafs_take2 - #224
Conversation
|
Thanks @cjbackhouse. Did you start with the latest version of the original branch? 05c2859. This looks based on an older version before some of the other comments were addressed |
|
Hang on. Maybe it didn't all take... |
…lls in SRHeader with one entry per event. More ideal is an entry per subrun.
… and CAFmaker. Output comes in same way as it did previously
d85756f to
58bab13
Compare
… and data label and using whichever one works.
|
OK, does this look right now? |
|
It does thanks. This looks good to me |
|
trigger build SBNSoftware/sbnanaobj#41 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
@cjbackhouse @jzettle CI fails here while SBNSoftware/sbnanaobj#41 succeed. Could you check it? |
|
I think @cjbackhouse should comment more but I think now he has added an abort if it doesn't see the POT information (I'm not experienced enough in art-based things to understand if this is a fcl label or the product itself is empty). I'm not sure what CI does but maybe it runs afoul of that new requirement I see the message |
|
Although looking at this again and maybe I'm getting my negatives wrong but I see it looks for |
|
You should be able to successfully make a CAF from a singles file if you set both the BNBPOTDataLabel and GenLabel to the empty string, indicating that you aren't expecting to find any POT information in the file. |
|
trigger build SBNSoftware/sbnanaobj#41 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
Thanks @cjbackhouse for your help in getting this all corrected and implemented! |
This was initially merged in #211 and reverted in #218
This PR adds one additional commit to the end that avoids dependency on fIsRealData by just trying both labels.
Depends on SBNSoftware/sbnanaobj#41