Skip to content

Greenlee pid update - #222

Merged
miquelnebot merged 8 commits into
SBNSoftware:developfrom
hgreenlee:greenlee_pid_update
Dec 21, 2021
Merged

miquelnebot merged 8 commits into
SBNSoftware:developfrom
hgreenlee:greenlee_pid_update

Conversation

@hgreenlee

Copy link
Copy Markdown
Contributor

Updates for new ParticleID data products.

@miquelnebot miquelnebot added the enhancement New feature or request label Dec 20, 2021
@miquelnebot

Copy link
Copy Markdown
Contributor

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

@hgreenlee could you check the CI errors?

@henrylay97

Copy link
Copy Markdown
Member

The SBND CI errors are understood. This is clean for SBND :)

@miquelnebot
miquelnebot self-requested a review December 21, 2021 16:25

@miquelnebot miquelnebot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Need for CI to work after larsoft 09_41_00
CI errors due to #223 , understood.

@miquelnebot
miquelnebot merged commit fadf0b3 into SBNSoftware:develop Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants