Skip to content

Update ICARUS detector location and detector box - #193

Merged
miquelnebot merged 1 commit into
developfrom
feature/mevprtl-numi-coord
Nov 18, 2021
Merged

miquelnebot merged 1 commit into
developfrom
feature/mevprtl-numi-coord

Conversation

@gputnam

@gputnam gputnam commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

Synchronizes the ICARUS-NuMI location with the neutrino simulation (SBNSoftware/icaruscode#230).

@wesketchum wesketchum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still be better to pull this in from a geo service ... particularly the active bounding box.

@miquelnebot

Copy link
Copy Markdown
Contributor

Would still be better to pull this in from a geo service ... particularly the active bounding box.

@wesketchum is that a request? or is this good to go?

@gputnam

gputnam commented Nov 17, 2021

Copy link
Copy Markdown
Contributor Author

If there was an available volume in the ICARUS Geometry then I would be happy to do it. But unfortunately, there is no volume that covers both cryostats without too much space outside of it.

@wesketchum

Copy link
Copy Markdown
Contributor

@gputnam thanks. we should figure out this for the future.

@miquelnebot sorry to confuse: was meant as a note but not needed for now. This looks ok to me to go.

@miquelnebot

Copy link
Copy Markdown
Contributor

trigger build

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@miquelnebot

Copy link
Copy Markdown
Contributor

ICARUS errors:

The following tests FAILED:
30 - testFHiCLfiles_icarus.sh (Failed)

Occurring across all PRs, so not an issue of this PR

@miquelnebot
miquelnebot merged commit 890cf66 into develop Nov 18, 2021
0.00136256111, 0.998103714, -0.061539578,
-0.389019125, 0.0572211871, 0.919450845 ]
icarus_numi_beam2detector_rotation: [ 0.921035925, 0.022715103, 0.388814672,
0, 0.998297825, -0.058321970

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gputnam @miquelnebot this is where the error crept in, no comma at end of this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants