Repository navigation
Update ICARUS detector location and detector box - #193
Conversation
wesketchum
left a comment
There was a problem hiding this comment.
Would still be better to pull this in from a geo service ... particularly the active bounding box.
@wesketchum is that a request? or is this good to go? |
|
If there was an available volume in the ICARUS Geometry then I would be happy to do it. But unfortunately, there is no volume that covers both cryostats without too much space outside of it. |
|
@gputnam thanks. we should figure out this for the future. @miquelnebot sorry to confuse: was meant as a note but not needed for now. This looks ok to me to go. |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase unit_test ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
ICARUS errors:
Occurring across all PRs, so not an issue of this PR |
| 0.00136256111, 0.998103714, -0.061539578, | ||
| -0.389019125, 0.0572211871, 0.919450845 ] | ||
| icarus_numi_beam2detector_rotation: [ 0.921035925, 0.022715103, 0.388814672, | ||
| 0, 0.998297825, -0.058321970 |
There was a problem hiding this comment.
@gputnam @miquelnebot this is where the error crept in, no comma at end of this line
Synchronizes the ICARUS-NuMI location with the neutrino simulation (SBNSoftware/icaruscode#230).