Skip to content

perf(ci): persist Dylint's nightly check tree with setup-soldr's output cache - #2076

Merged
zackees merged 1 commit into
mainfrom
perf/dylint-output-cache
Nov 18, 2026
Merged

zackees merged 1 commit into
mainfrom
perf/dylint-output-cache

Conversation

@zackees

@zackees zackees commented Nov 18, 2026

Copy link
Copy Markdown
Member

Why

Dylint builds the workspace with its own pinned nightly, so none of the stable build caches cover it, and every run recompiles from scratch (~16 min). After #2071 stopped the janitor deleting the build cache, main restores it (HIT, 696 MB), but zccache still reports hits=0 misses=496 on the nightly compiles. obs-rust's answer is a warm, persisted Dylint target tree.

What

  • dylint.yml: dylint-output-cache: true. setup-soldr saves target/dylint/{libraries,target}/<nightly>-<host> after a successful run.
    • It was off because its key used to include the commit SHA. setup-soldr#540 made it commit-free: toolchain, driver, manifests, target shape and Cargo.lock, with a restore that drops only the lockfile. Cargo fingerprints recheck whatever changed.
    • Drops the bespoke short-path lint-library cache: the restore, the qualified→short symlink and the save. The output cache supersedes it, and the symlink step would collide with the restored qualified directory.
  • local-gate.toml: the dylint replay step list follows the removed steps.
  • ci.toml: declares the dylint-output family (via = "setup-soldr:dylint-output"), so the janitor keeps it, and retires fbuild-dylint-libraries-.

Validation

  • ci.test_fractional_workflows contract updated first (output cache on, bespoke steps gone). That suite plus test_local_dylint_gate, test_local_gate, test_local_suites, test_gate_script_coverage, test_setup_soldr_cache_keys and test_setup_action: 69 tests OK. render_workflows.py --check passes.
  • Live ci_lint cache audit (pin 635fb12) vs main's ci.toml:
    • dylint-libs CACHE-004 overrun removed;
    • the retired libraries entry flagged CACHE-009, which is intended;
    • no other change.
  • The cache is only saved on main, so the speedup shows on the second main Dylint run after merge. I'll follow up with its timing.

…ut cache

Dylint compiles the workspace with its own pinned nightly, so the stable
build caches never cover it, and every run recompiled the whole tree
(~16 min; zccache hits=0 even after #2071 kept the build
cache alive). obs-rust's answer is a warm, persisted Dylint target tree.

setup-soldr's `dylint-output-cache` saves target/dylint/{libraries,target}/
<nightly>-<host> after a successful run. It was disabled here because its
key used to include the commit SHA. setup-soldr#540 made it commit-free
(toolchain, driver, manifests, target shape, Cargo.lock; restore drops only
the lockfile), and cargo's fingerprints recheck what changed. Enable it.

It supersedes the bespoke short-path lint-library cache, whose restore
plus qualified->short symlink would collide with the restored qualified
directory, so those three steps go. local-gate.toml's dylint replay step
list follows. ci.toml declares the `dylint-output` family, so the janitor
keeps it, and retires `fbuild-dylint-libraries-`. The live audit then
drops the dylint-libs CACHE-004 overrun and flags the retired entry for
deletion (CACHE-009), with no other change.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zackees
zackees added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit d12f7ae Nov 18, 2026
29 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant