Repository navigation
perf(ci): persist Dylint's nightly check tree with setup-soldr's output cache - #2076
Merged
Merged
Conversation
…ut cache Dylint compiles the workspace with its own pinned nightly, so the stable build caches never cover it, and every run recompiled the whole tree (~16 min; zccache hits=0 even after #2071 kept the build cache alive). obs-rust's answer is a warm, persisted Dylint target tree. setup-soldr's `dylint-output-cache` saves target/dylint/{libraries,target}/ <nightly>-<host> after a successful run. It was disabled here because its key used to include the commit SHA. setup-soldr#540 made it commit-free (toolchain, driver, manifests, target shape, Cargo.lock; restore drops only the lockfile), and cargo's fingerprints recheck what changed. Enable it. It supersedes the bespoke short-path lint-library cache, whose restore plus qualified->short symlink would collide with the restored qualified directory, so those three steps go. local-gate.toml's dylint replay step list follows. ci.toml declares the `dylint-output` family, so the janitor keeps it, and retires `fbuild-dylint-libraries-`. The live audit then drops the dylint-libs CACHE-004 overrun and flags the retired entry for deletion (CACHE-009), with no other change.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dylint builds the workspace with its own pinned nightly, so none of the stable build caches cover it, and every run recompiles from scratch (~16 min). After #2071 stopped the janitor deleting the build cache,
mainrestores it (HIT, 696 MB), but zccache still reportshits=0 misses=496on the nightly compiles. obs-rust's answer is a warm, persisted Dylint target tree.What
dylint.yml:dylint-output-cache: true. setup-soldr savestarget/dylint/{libraries,target}/<nightly>-<host>after a successful run.Cargo.lock, with a restore that drops only the lockfile. Cargo fingerprints recheck whatever changed.local-gate.toml: the dylint replay step list follows the removed steps.ci.toml: declares thedylint-outputfamily (via = "setup-soldr:dylint-output"), so the janitor keeps it, and retiresfbuild-dylint-libraries-.Validation
ci.test_fractional_workflowscontract updated first (output cache on, bespoke steps gone). That suite plustest_local_dylint_gate,test_local_gate,test_local_suites,test_gate_script_coverage,test_setup_soldr_cache_keysandtest_setup_action: 69 tests OK.render_workflows.py --checkpasses.ci_lint cache audit(pin 635fb12) vs main'sci.toml:dylint-libsCACHE-004 overrun removed;main, so the speedup shows on the secondmainDylint run after merge. I'll follow up with its timing.