Repository navigation
perf(ci): make ci-minimal's three-target Dylint call the only main writer - #2079
Merged
Merged
Conversation
…iter dylint.yml ran twice on every main push: once from its own push trigger (Linux only) and once from ci-minimal's workflow_call (Linux, Windows and macOS). Both computed the same setup-soldr dylint-output-cache key, and the faster Linux-only run always won the save (the other logged 'save skipped (id=-1) - likely concurrent save'). So the Windows/macOS check tree was never persisted and ci-minimal's Dylint call stayed ~16 min, while the standalone run dropped from ~8.5 to ~3.3 min once the cache was warm. Drop the standalone push trigger. ci-minimal's main-push call already covers a superset of it, now seeds the three-target tree that PRs restore, and main stops paying for Dylint twice.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #2076,
dylint.ymlstill ran twice on everymainpush: once from its ownpushtrigger (Linux only) and once from ci-minimal'sworkflow_call(Linux, Windows and macOS). Both computed the same setup-soldrdylint-output-cachekey. The faster Linux-only run always saved first, and the other loggedsave skipped (id=-1) - likely concurrent save.Measured on main:
So the Windows and macOS halves of the nightly tree were never persisted.
What
push: maintrigger. ci-minimal's main-push call already covers a superset of it.mainstops paying for Dylint twice.ci.test_fractional_workflowscontract now asserts there is nopushtrigger (updated first, red → green).Validation
ci.test_fractional_workflows,test_local_dylint_gateandtest_local_gatepass: 37 tests OK.render_workflows.py --checkpasses.