Skip to content

perf(ci): make ci-minimal's three-target Dylint call the only main writer - #2079

Merged
zackees merged 1 commit into
mainfrom
perf/dylint-single-writer
Nov 18, 2026
Merged

zackees merged 1 commit into
mainfrom
perf/dylint-single-writer

Conversation

@zackees

@zackees zackees commented Nov 18, 2026

Copy link
Copy Markdown
Member

Why

After #2076, dylint.yml still ran twice on every main push: once from its own push trigger (Linux only) and once from ci-minimal's workflow_call (Linux, Windows and macOS). Both computed the same setup-soldr dylint-output-cache key. The faster Linux-only run always saved first, and the other logged save skipped (id=-1) - likely concurrent save.

Measured on main:

Run Dylint job Output cache
standalone (Linux) 08:15, 08:27 3.3 min (was ~8.5) HIT; zccache 32 hits / 59 misses
ci-minimal (3 targets) 08:10, 08:13 12–16 min MISS, save lost the race

So the Windows and macOS halves of the nightly tree were never persisted.

What

  • Drop the standalone push: main trigger. ci-minimal's main-push call already covers a superset of it.
    • That call becomes the single writer of the three-target tree that PRs restore.
    • main stops paying for Dylint twice.
  • The ci.test_fractional_workflows contract now asserts there is no push trigger (updated first, red → green).

Validation

ci.test_fractional_workflows, test_local_dylint_gate and test_local_gate pass: 37 tests OK. render_workflows.py --check passes.

…iter

dylint.yml ran twice on every main push: once from its own push trigger
(Linux only) and once from ci-minimal's workflow_call (Linux, Windows and
macOS). Both computed the same setup-soldr dylint-output-cache key, and the
faster Linux-only run always won the save (the other logged 'save skipped
(id=-1) - likely concurrent save'). So the Windows/macOS check tree was
never persisted and ci-minimal's Dylint call stayed ~16 min, while the
standalone run dropped from ~8.5 to ~3.3 min once the cache was warm.

Drop the standalone push trigger. ci-minimal's main-push call already
covers a superset of it, now seeds the three-target tree that PRs restore,
and main stops paying for Dylint twice.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zackees
zackees added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 8109d92 Nov 18, 2026
30 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant