Repository navigation
fix(ci): stop the cache janitor deleting Dylint's compile cache and verdicts - #2071
Merged
Merged
Conversation
…erdicts Every Dylint run restored no build cache and got 0% zccache hits (hits=0 misses=496 on each main run), so the nightly workspace check recompiled from scratch for ~16 minutes. The cache was saved fine; the end-of-queue `ci_lint cache janitor` then deleted it: - CACHE-001 "undeclared family": `[cache.family.compile]` used `via = "setup-soldr:build-cache"`, which ci_lint still resolves to the `setup-soldr-buildcache-v2-` prefix. setup-soldr writes `-v3-`, so every live compile cache (Dylint's included) was classified as undeclared and swept. Declare the literal `-v3-` prefix instead. - CACHE-005 "poisoned": soldr verdict records (the ledger that lets `soldr dylint` skip a run whose inputs match a passing one) are ~450 B by design, below the 1 KB poison floor. Declare `min = "0B"` on the verdict family and bump the linter pin to 635fb12, the first ci.yml revision where a declared `min` replaces the floor (#417). Live audit against FastLED/fbuild with the new pin: CACHE-001 15 -> 8 (all remaining are tiny target-cache stubs), CACHE-005 46 -> 9. `ci_lint precheck` findings are unchanged.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
ci-minimal.yml's queue-cache-janitor (the one that swept the Dylint build cache) checks out its own pin, 953c4e1, which the first commit missed. Move it to 635fb12 (38 commits ahead, same lineage) so it reads the fixed compile/verdict families.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dylint is slow (~16 min for "Run dylint over workspace" on main) because its nightly-compiler build cache is never reused. Every main run logs
build-cache MISS (no match)on restore andhits=0 misses=496 hit_rate=0.0%. The cache is saved; the end-of-queueci_lint cache janitordeletes it afterwards:[cache.family.compile]usedvia = "setup-soldr:build-cache". The ci_lint linter still maps that tosetup-soldr-buildcache-v2-, but setup-soldr writes-v3-. So every live compile cache, the Dylint one included, was swept as undeclared.soldr dylintskip a run whose inputs match a passing run) are ~450 B by design, which is under the 1 KB poison floor. So the skip fast path was wiped too.Fix
compilefamily declares the literalprefix = "setup-soldr-buildcache-v3-".verdictfamily declaresmin = "0B".minreplaces the 1 KB floor (Symbol/size analysis: detect or prevent map-file 0x00000000 false positives (~95 KB phantom-bloat reported on FastLED#2473) #417). The pin is updated in ci.toml, render_workflows.py, ci-minimal.yml and dylint.yml.Validation
ci_lint cache auditagainst the live FastLED/fbuild cache listing with the new pin:targetcache-thinstubs.ci_lint precheck --local(with PyYAML): identical findings before and after.render_workflows.py --checkpasses;ci.test_fractional_workflowsandci.test_local_dylint_gatepass.The upstream ci.yml
setup-soldr:build-cacheshape still names-v2-; that should be fixed in zackees/ci.yml separately.