Skip to content

fix(ci): provision cold Linux capacity through the Android SDK manager - #1892

Merged
zackees merged 2 commits into
mainfrom
fix/ci-cold-build-disk
Nov 4, 2026
Merged

zackees merged 2 commits into
mainfrom
fix/ci-cold-build-disk

Conversation

@zackees

@zackees zackees commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Fresh Linux builders for the 2.5.51 release started with only 11.91–12.48 GiB available. Legitimate cross SDK downloads and Rust outputs then hit the existing 5 GiB capacity guards: ESP32-P4 acceptance had 4.14 GB free, GNU glibc-floor cross-linking 1.86 GiB, macOS ARM sidecar repair 3.57 GiB, and Linux ARM musl extension preparation 2.37 GiB. The target cache was cold, so deleting or disabling restored Rust caches would not solve the provisioning gap.

Before those builds, uninstall only the unused Android NDK packages supplied by the GitHub-hosted Linux image. A shared CI helper reads installed SDK package metadata, validates the exact NDK IDs, and delegates removal to sdkmanager with the explicit SDK root. It records workspace free bytes before and after. Its entrypoint refuses local, self-hosted, and non-Linux execution. The reusable native template also skips the operation on other runners.

The helper is used by four existing workflow paths: acceptance, glibc-floor, the all-OS Dylint Linux builder, and Linux native release builds. The initial PR sweep exposed the same capacity guard in Dylint at 3.99 GiB while preparing its Windows cross-check, so that actual consumer is included too. Other Android packages, Rust/fbuild caches, and all disk guards remain unchanged. No workflow files or production Rust behavior are added.

Validation: five focused tests cover installed metadata selection, no-op behavior, invalid metadata, hosted-only guards, and actual subprocess arguments through a temporary SDK-manager recorder. Ruff, Python complexity, workflow concurrency checks, and independent review passed. The PR sweep measured about 6.49 GiB reclaimed from three installed NDKs; cold P4 acceptance and both GNU glibc-floor architectures passed. Both final-head Dylint jobs passed too: one started with 13,880,700,928 free bytes, reclaimed 6,968,242,176 bytes, and completed its cross-target checks with the 5 GiB guard enabled (5.87 GiB remained at the later check). The final head must complete the rest of its full sweep before merge. ci-full was applied at creation. The subsequent exact-candidate release must also prove the native release cross-build profiles.

The failing exact-candidate release is https://github.com/FastLED/fbuild/actions/runs/41808037950. This follows #1887 and #1888 and unblocks the 2.5.51 consumer cascade for FastLED/FastLED#5015.

@zackees zackees added the ci-full Run the complete release-equivalent CI matrix on this PR SHA label Nov 4, 2026
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zackees
zackees added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 9b26aff Nov 4, 2026
135 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Nov 5, 2026
@zackees
zackees deleted the fix/ci-cold-build-disk branch November 5, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full Run the complete release-equivalent CI matrix on this PR SHA

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant