You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): make archive regression portable and rerun summaries reliable - #1888
The framework archive-policy regression introduced in #1887 tried to execute a POSIX fake archiver on Windows. The release dry run failed before reaching its policy assertions.
Prime a matching-identity cached archive directly, verify that the default policy selects it, and then disable archiving with an intentionally missing archiver executable. The test still requires both object files, so Windows retains coverage of bypassing a warm archive without needing a shell. Production code is unchanged; native Linux integration tests separately exercise actual archive creation and linking.
The full validation also exposed persistent GitHub HTTP 502 responses when the summary requested 100 jobs per page on reruns. Use the default 30-job page size while retaining pagination, retries, and all failure checks. The real failing run now returns all 126 jobs through the gate; failed later-page jobs remain covered by regression tests.
Validation: the Windows release dry run provides the failing fixture regression; the corrected test passes locally and on the hosted Windows full suite. The page-size regression failed before the gate change; all eight gate tests and Ruff now pass. Formatting, canonical workspace Clippy with warnings denied, and independent review passed. The ci-full label was applied at creation; the final head must pass full coverage before merge.
Follow-up for #1885; coordinated with FastLED/FastLED#5015. Version 2.5.51 remains unpublished pending a successful exact-commit release dry run.
No actionable comments were generated in the recent review.
Walkthrough
The archive-override test now writes a local framework archive between planning calls and checks that the second plan selects it as cached. The test also sets the archiver path to a nonexistent executable before the direct-object compilation path.
Changes: Framework archive override test
Layer / File(s)
Summary
Cached archive and direct-object test crates/fbuild-build-esp/src/esp32/orchestrator/framework_libs_tests.rs
The test writes a local libfs.a between planning calls and checks that the second plan selects FwLibEntry::Cached. It sets ar_path to a nonexistent path before exercising direct-object compilation.
The portable archive-policy test change has no established merge-blocking risk.
Pre-merge checks: 4 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Title check
The title says the PR fixes CI and makes the archive regression portable and reruns summaries reliable. The raw summary and objectives describe only a test change in framework_libs_tests.rs that prime…
Narrow the title to the change that the diff contains, for example: test(esp32): keep archive policy coverage portable to Windows. If CI workflow or rerun-summary changes are in the PR, confirm they are in the changeset and keep them in the…
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Full details: Title check
Explanation
The title says the PR fixes CI and makes the archive regression portable and reruns summaries reliable. The raw summary and objectives describe only a test change in framework_libs_tests.rs that primes a cached archive and uses a missing archiver executable so the test runs on Windows. The archive-regression part matches the changeset. The 'fix(ci)' scope and the 'rerun summaries reliable' clause are not supported by the provided summary, which lists no CI workflow or summary-rerun change. The title is therefore partially related to the change and overstates its scope.
Resolution
Narrow the title to the change that the diff contains, for example: test(esp32): keep archive policy coverage portable to Windows. If CI workflow or rerun-summary changes are in the PR, confirm they are in the changeset and keep them in the title.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
zackees
changed the title
test(esp32): keep archive policy coverage portable to Windows
fix(ci): make archive regression portable and rerun summaries reliable
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci-fullRun the complete release-equivalent CI matrix on this PR SHA
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework archive-policy regression introduced in #1887 tried to execute a POSIX fake archiver on Windows. The release dry run failed before reaching its policy assertions.
Prime a matching-identity cached archive directly, verify that the default policy selects it, and then disable archiving with an intentionally missing archiver executable. The test still requires both object files, so Windows retains coverage of bypassing a warm archive without needing a shell. Production code is unchanged; native Linux integration tests separately exercise actual archive creation and linking.
The full validation also exposed persistent GitHub HTTP 502 responses when the summary requested 100 jobs per page on reruns. Use the default 30-job page size while retaining pagination, retries, and all failure checks. The real failing run now returns all 126 jobs through the gate; failed later-page jobs remain covered by regression tests.
Validation: the Windows release dry run provides the failing fixture regression; the corrected test passes locally and on the hosted Windows full suite. The page-size regression failed before the gate change; all eight gate tests and Ruff now pass. Formatting, canonical workspace Clippy with warnings denied, and independent review passed. The
ci-fulllabel was applied at creation; the final head must pass full coverage before merge.Follow-up for #1885; coordinated with FastLED/FastLED#5015. Version 2.5.51 remains unpublished pending a successful exact-commit release dry run.