Skip to content

fix(library): honor archive policy and invalidate incremental links - #1887

Merged
zackees merged 6 commits into
mainfrom
feat/assembly-library-dispatch
Nov 4, 2026
Merged

zackees merged 6 commits into
mainfrom
feat/assembly-library-dispatch

Conversation

@zackees

@zackees zackees commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Explicit lib_archive settings and each library's build.libArchive setting now control whether the linker receives an archive or every object directly. Environment settings take precedence, cached archives are bypassed when disabled, and core extraction remains independent.

The policy flows through project, downloaded, local, extra, and bundled framework libraries. Configuration participates in the fast-path fingerprint, preventing reuse of a binary linked under a previous policy. Existing archive-returning APIs preserve their contracts. The version advances to 2.5.51 for the consumer release.

The assembly-driver fix from #1886 is preserved. This PR adds native coverage for its target flags and compile signatures alongside the archive regressions.

Validation: 1,553 affected unit tests passed across five crates; after integrating #1886, all 323 library unit tests passed. Real native GCC tests cover assembly dispatch, weak/strong overrides, cached archives, and core ISR extraction. A five-phase incremental test changes manifest true→false→true and environment overrides on the same build root and executable while source code stays unchanged, verifying production fast-path misses, actual relinks, runtime behavior, and warm-hit controls. These native regressions run in the existing Linux CI workflow. Formatting, workspace/toolchain guards, canonical workspace Clippy with warnings denied, full workspace Dylint, and independent review passed before base integration; the changed library package is checked again after integration.

Fixes #1885.

Coordinated with FastLED/FastLED#5015 and the investigation of FastLED/FastLED#5013. The consumer contains the reported SAMD assembly metadata fix; these backend defects have their own native regressions.

Use the C driver for preprocessed and raw library assembly and hash the same invocation for incremental rebuilds. Preserve C++ handling of uppercase .C sources. Covers compiler dispatch, CPU flag retention, signature invalidation, and a native GCC preprocessor regression. Refs #1885; coordinated with FastLED/FastLED#5013.
Apply explicit environment precedence over library manifests, link all objects directly when archiving is disabled, and retain independent core extraction. Include archive policy in fast-path metadata and bypass warm framework archives when disabled. Native GCC regressions verify strong overrides, core ISRs, and same-root incremental policy toggles; run them in the existing Linux gate. Fixes #1885; coordinated with FastLED/FastLED#5015.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…-dispatch

# Conflicts:
#	crates/fbuild-library/src/library/library_compiler.rs
#	crates/fbuild-library/src/library/library_compiler_tests.rs
@zackees zackees changed the title fix(library): respect assembly flags and archive policy fix(library): honor archive policy and invalidate incremental links Nov 4, 2026
@zackees
zackees added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit e9ece7e Nov 4, 2026
54 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Nov 5, 2026
@zackees
zackees deleted the feat/assembly-library-dispatch branch November 5, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

Library assembly uses C++ dispatch and explicit loose-object policy is ignored

1 participant