Repository navigation
fix(library): honor archive policy and invalidate incremental links - #1887
Merged
Merged
Conversation
Use the C driver for preprocessed and raw library assembly and hash the same invocation for incremental rebuilds. Preserve C++ handling of uppercase .C sources. Covers compiler dispatch, CPU flag retention, signature invalidation, and a native GCC preprocessor regression. Refs #1885; coordinated with FastLED/FastLED#5013.
Apply explicit environment precedence over library manifests, link all objects directly when archiving is disabled, and retain independent core extraction. Include archive policy in fast-path metadata and bypass warm framework archives when disabled. Native GCC regressions verify strong overrides, core ISRs, and same-root incremental policy toggles; run them in the existing Linux gate. Fixes #1885; coordinated with FastLED/FastLED#5015.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
…-dispatch # Conflicts: # crates/fbuild-library/src/library/library_compiler.rs # crates/fbuild-library/src/library/library_compiler_tests.rs
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit
lib_archivesettings and each library'sbuild.libArchivesetting now control whether the linker receives an archive or every object directly. Environment settings take precedence, cached archives are bypassed when disabled, and core extraction remains independent.The policy flows through project, downloaded, local, extra, and bundled framework libraries. Configuration participates in the fast-path fingerprint, preventing reuse of a binary linked under a previous policy. Existing archive-returning APIs preserve their contracts. The version advances to 2.5.51 for the consumer release.
The assembly-driver fix from #1886 is preserved. This PR adds native coverage for its target flags and compile signatures alongside the archive regressions.
Validation: 1,553 affected unit tests passed across five crates; after integrating #1886, all 323 library unit tests passed. Real native GCC tests cover assembly dispatch, weak/strong overrides, cached archives, and core ISR extraction. A five-phase incremental test changes manifest true→false→true and environment overrides on the same build root and executable while source code stays unchanged, verifying production fast-path misses, actual relinks, runtime behavior, and warm-hit controls. These native regressions run in the existing Linux CI workflow. Formatting, workspace/toolchain guards, canonical workspace Clippy with warnings denied, full workspace Dylint, and independent review passed before base integration; the changed library package is checked again after integration.
Fixes #1885.
Coordinated with FastLED/FastLED#5015 and the investigation of FastLED/FastLED#5013. The consumer contains the reported SAMD assembly metadata fix; these backend defects have their own native regressions.