Skip to content

chore: remove dead code (closes #60) - #61

Merged
zackees merged 1 commit into
mainfrom
chore/issue-60-dead-code-cleanup
May 12, 2026
Merged

zackees merged 1 commit into
mainfrom
chore/issue-60-dead-code-cleanup

Conversation

@zackees

@zackees zackees commented May 12, 2026

Copy link
Copy Markdown
Member

Summary

Removes confirmed dead code identified in #60. All items were verified by full-repo grep — zero references in src/, tests/, .github/, scripts, or entry points.

Deleted files

  • src/fastled/cli_test.py — manual debug script, not in entry points, not imported
  • src/fastled/cli_test_interactive.py — same shape
  • src/fastled/install/test_install.py — unittest module orphaned outside tests/unit/; pytest never collects it

Deleted symbols

  • Tools class in src/fastled/__init__.py — not in __all__, zero callers
  • CompileOrLink enum in src/fastled/print_filter.py — zero references
  • _handle_ino_cpp helper in src/fastled/print_filter.py — zero callers

Retained

  • safe_print() in src/fastled/emoji_util.py — .cursorrules documents it as the recommended Unicode-safe print utility.

Test plan

  • bash lint — clean (0 pyright errors / warnings)
  • Affected tests pass in isolation (tests/unit/test_filechanger.py flake under suite-load is pre-existing and unrelated to these changes)
  • CI green on the PR

Closes #60

🤖 Generated with Claude Code

- Delete orphan debug scripts: cli_test.py, cli_test_interactive.py
  (manual run-from-IDE entry points; not registered, not imported).
- Delete src/fastled/install/test_install.py — unittest module never
  collected (test runner only scans tests/unit/) and never imported.
- Remove Tools class from __init__.py — not in __all__, zero callers,
  only wraps a one-line string_diff import.
- Remove CompileOrLink enum and _handle_ino_cpp helper from
  print_filter.py — both have zero references; PrintFilterDefault.filter
  returns text unchanged and never invokes the helper.

safe_print() in emoji_util.py is intentionally retained: .cursorrules
documents it as the recommended Unicode-safe print utility.

Lint clean. Affected tests pass in isolation.
@zackees
zackees merged commit d3aa1b3 into main May 12, 2026
25 checks passed
zackees added a commit that referenced this pull request May 13, 2026
Sweeps the non-Python items issue #59 flagged that are still on main
after PRs #61, #62, #64, #65, #66, #68 cleaned up the Python side:

* `entrypoint.sh` — Docker container entrypoint. Sourced
  `/emsdk/emsdk_env.sh` (container path) and called
  `fastled_wasm_compiler.cli_update_from_master` (a module from a
  separate package that only exists inside the container).
* `compiler/run.py` — Docker compile-server entry point. Imports
  `fastled_wasm_compiler`, a separate package not in this repo.
* `compiler/debug.sh` — instructed user to run from `/js` (container
  working directory). Empty `compiler/` directory removed.
* `.dockerignore` — only contained cache exclusions
  (`**/.mypy_cache/`, `**/.ruff_cache/`) which belong in `.gitignore`
  if anywhere; no Docker build context this could serve.
* `chrome_vscode_bridge_design_task.md` — one-off design draft that
  opens with "Here's a refined ... file for your repo. Feel free to
  adjust...". Zero references anywhere else.
* `upload_package.sh` — manual PyPI upload helper, superseded by the
  automated `publish_release.yml` workflow. Zero inbound references.
* Empty root-level `fastled/` directory left over from a prior layout.

`lint` script updated to stop passing the (now-deleted) `compiler/` path
to ruff / black / isort / pyright / the keyboard-interrupt checker.

`bash lint` clean. `bash test` — 119 pass.

Verified by grep across `*.py`, `*.rs`, `*.toml`, `*.yml`, `*.sh`,
`*.md`, `Cargo.toml` (excluding `.venv/` and `.claude/worktrees/`):
none of the deleted files are referenced from a live code path or
workflow.
@zackees
zackees deleted the chore/issue-60-dead-code-cleanup branch November 5, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead code cleanup: remove unused module-level symbols and orphan scripts

1 participant