Skip to content

Dead code cleanup: remove unused module-level symbols and orphan scripts #60

Closed

Description

@zackees

Audit of src/fastled/ found the following code with zero references in the repo (production code, tests, CI workflows, entry points). Each item below has been verified by full-repo grep against the codebase (excluding .claude/worktrees/).

Dead symbols

Tools class — src/fastled/__init__.py:35-41

  • Defined but never imported anywhere. Not in __all__ (which lists Api, Test, etc.).
  • Only wraps a single string_diff call; callers can import directly.

CompileOrLink enum — src/fastled/print_filter.py:50-52

  • No references in src/, tests/, or .github/. Never imported, never compared, never serialized.

_handle_ino_cpp function — src/fastled/print_filter.py:27-40

  • Module-private helper with no callers. PrintFilterDefault.filter() returns text unchanged and never invokes it.

Orphan modules

src/fastled/cli_test.py

  • Standalone debug script with hardcoded os.chdir("../fastled") and example name. Not registered as an entry point in pyproject.toml, not imported anywhere. Comment in file says ""entry point for the exe is in cli.py"".

src/fastled/cli_test_interactive.py

  • Same shape as cli_test.py — manual debug script, not wired to anything.

src/fastled/install/test_install.py

  • Unittest module placed inside src/ rather than tests/unit/. The test runner only invokes pytest ... tests/unit, so this file is never collected. Never imported elsewhere.

Scope

Removal-only — no behavioral changes. safe_print() in src/fastled/emoji_util.py is intentionally kept even though currently unused: .cursorrules documents it as the recommended Unicode-safe print utility for contributors.

Acceptance

  • bash lint clean.
  • bash test passes (unit tests under tests/unit/).
  • Files deleted entirely where the whole file is dead; symbol-level removals leave the surrounding module intact.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions