Repository navigation
chore: remove Docker remnants + dead shell scripts (closes #59) - #70
Merged
Merged
Conversation
Sweeps the non-Python items issue #59 flagged that are still on main after PRs #61, #62, #64, #65, #66, #68 cleaned up the Python side: * `entrypoint.sh` — Docker container entrypoint. Sourced `/emsdk/emsdk_env.sh` (container path) and called `fastled_wasm_compiler.cli_update_from_master` (a module from a separate package that only exists inside the container). * `compiler/run.py` — Docker compile-server entry point. Imports `fastled_wasm_compiler`, a separate package not in this repo. * `compiler/debug.sh` — instructed user to run from `/js` (container working directory). Empty `compiler/` directory removed. * `.dockerignore` — only contained cache exclusions (`**/.mypy_cache/`, `**/.ruff_cache/`) which belong in `.gitignore` if anywhere; no Docker build context this could serve. * `chrome_vscode_bridge_design_task.md` — one-off design draft that opens with "Here's a refined ... file for your repo. Feel free to adjust...". Zero references anywhere else. * `upload_package.sh` — manual PyPI upload helper, superseded by the automated `publish_release.yml` workflow. Zero inbound references. * Empty root-level `fastled/` directory left over from a prior layout. `lint` script updated to stop passing the (now-deleted) `compiler/` path to ruff / black / isort / pyright / the keyboard-interrupt checker. `bash lint` clean. `bash test` — 119 pass. Verified by grep across `*.py`, `*.rs`, `*.toml`, `*.yml`, `*.sh`, `*.md`, `Cargo.toml` (excluding `.venv/` and `.claude/worktrees/`): none of the deleted files are referenced from a live code path or workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up the non-Python items issue #59 flagged that survived the prior Python-focused sweeps (PRs #61, #62, #64, #65, #66, #68). All confirmed dead by full-repo grep across
*.py,*.rs,*.toml,*.yml,*.sh,*.md,Cargo.toml.Deleted
entrypoint.sh— Docker container entrypoint. Sourced/emsdk/emsdk_env.sh(container path) and invokedfastled_wasm_compiler.cli_update_from_master, a module from a separate package that only exists inside the container.compiler/run.py— Docker compile-server entry point. Importsfastled_wasm_compiler, not in this repo.compiler/debug.sh— instructed user to run from/js(container working dir). Emptycompiler/directory removed too..dockerignore— contained only**/.mypy_cache/and**/.ruff_cache/; no Docker build context this could serve.chrome_vscode_bridge_design_task.md— one-off design draft that opens with "Here's a refined ... file for your repo. Feel free to adjust...". Zero references anywhere.upload_package.sh— manual PyPI uploader, superseded bypublish_release.yml's automated PyPI publish.fastled/directory left over from a prior layout.lintscript updateRemoved the (now-deleted)
compiler/path from ruff / black / isort / pyright / the keyboard-interrupt checker invocations.Test plan
bash lintcleanbash test— 119 passCloses #59
🤖 Generated with Claude Code