Repository navigation
Show only each suite's default Vortex scan on bench #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7fbe334
c1064ef
4d03118
f09216d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ import { | |
| STRING_DATASET_PREFIX, | ||
| } from './compression-suite'; | ||
| import { groupDescription } from './descriptions'; | ||
| import type { FilterUniverse } from './chart-format'; | ||
| import { type FilterUniverse, isOtherScan } from './chart-format'; | ||
| import { type ChartKind, compareCodeUnits, FAMILIES, type GroupKind } from './families'; | ||
| import { chartKeyFromSlug, chartKeyToSlug, groupKeyFromSlug, groupKeyToSlug } from './slug'; | ||
| import type { ChartKey, GroupKey } from './slug'; | ||
|
|
@@ -402,13 +402,19 @@ export function seriesFor( | |
| } | ||
| } | ||
|
|
||
| /** Thread one fact row onto the seeded x-axis. A row off the seeded commits is dropped. */ | ||
| /** | ||
| * Thread one fact row onto the seeded x-axis. A row off the seeded commits is dropped, and so | ||
| * is a row of one of Vortex's other scans (`isOtherScan`). | ||
| */ | ||
| function recordRow(acc: SeriesAccumulator, kind: ChartKind, row: FactRow): void { | ||
| const idx = acc.commitIdx(row.commit_sha); | ||
| if (idx === undefined) { | ||
| return; | ||
| } | ||
| const { key, engine, format } = seriesFor(kind, row); | ||
| if (format !== undefined && isOtherScan(format)) { | ||
| return; | ||
|
Comment on lines
+415
to
+416
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a discovered query has rows only for an alternate Vortex scan—for example after the default scan fails or is not emitted—the seed/ Useful? React with 👍 / 👎. |
||
| } | ||
| acc.record(key, idx, row.value); | ||
| acc.tag(key, engine, format); | ||
| } | ||
|
|
@@ -1973,6 +1979,9 @@ export async function collectFilterUniverse(): Promise<FilterUniverse> { | |
| ]); | ||
| return { | ||
| engines: engines.rows.map((r) => r.value).sort(compareCodeUnits), | ||
| formats: formats.rows.map((r) => r.value).sort(compareCodeUnits), | ||
| formats: formats.rows | ||
| .map((r) => r.value) | ||
| .filter((format) => !isOtherScan(format)) | ||
| .sort(compareCodeUnits), | ||
| }; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isOtherScancurrently classifies every format ending in a bracketed qualifier as an alternate Vortex scan, even though the documented convention is specificallyvortex-file-compressed [...]. Because this predicate is used byrecordRowfor all chart families and bycollectFilterUniverse, any legitimate non-Vortex format such asparquet [custom]is silently removed from charts and filter chips; require thevortex-file-compressed [prefix before matching the suffix.Useful? React with 👍 / 👎.