Skip to content

Show only each suite's default Vortex scan on bench - #233

Merged
lwwmanning merged 4 commits into
mainfrom
wm/vortex-scan-display-names
Nov 21, 2026
Merged

lwwmanning merged 4 commits into
mainfrom
wm/vortex-scan-display-names

Conversation

@lwwmanning

@lwwmanning lwwmanning commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

This changes which Vortex series bench shows on its charts, summary cards, and Format filter. It does not change the database or the ingest.

Before, bench drew each of Vortex's other scans as its own series. For example, the ClickBench summary had duckdb:vortex-file-compressed [file, v1] beside duckdb:vortex. vortex-data/vortex#11685 added these scans on develop. After, bench shows one Vortex series for each engine, the suite's default scan, as vortex.

The rows stay in the database, because the pull request benchmark reports read their develop baseline from it and compare every scan. The methodology page now says which scan bench shows.

🤖 Generated with Claude Code

develop now runs Vortex's other scans as formats such as
vortex-file-compressed [file, v1]. The display rename matched only the
bare format, so those series showed the legacy name. They now read
vortex [file, v1] on charts and summaries, and Vortex (file, v1) in
llms.txt.

Signed-off-by: Will Manning <will@willmanning.io>
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
vortex.dev Ready Ready Preview Nov 21, 2026 3:45pm UTC

Request Review

@lwwmanning
lwwmanning marked this pull request as ready for review November 21, 2026 15:15
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🔦 Lighthouse audit

URL Profile Perf A11y Best practices SEO
/ desktop 🟢 100 🟢 100 🟢 100 🟢 100
/ mobile 🟢 94 🟢 100 🟢 96 🟢 100
/bench desktop 🟢 100 🟢 100 🟢 100 🟢 100
/bench mobile 🟢 95 🟢 100 🟢 100 🟢 100
/bench/chart/ct.eyJrIjoiQ29tcHJlc3Npb25UaW1lIiwiZGF0YXNldCI6ImFyYWRlIiwiZGF0YXNldF92YXJpYW50IjpudWxsfQ desktop 🟢 99 🟢 100 🟢 100 🟢 100
/bench/chart/ct.eyJrIjoiQ29tcHJlc3Npb25UaW1lIiwiZGF0YXNldCI6ImFyYWRlIiwiZGF0YXNldF92YXJpYW50IjpudWxsfQ mobile 🟢 92 🟢 100 🟢 96 🟢 100
/bench/methodology desktop 🟢 100 🟢 100 🟢 100 🟢 100
/bench/methodology mobile 🟢 98 🟢 100 🟢 100 🟢 100
/blog desktop 🟢 100 🟢 100 🟢 100 🟢 100
/blog mobile 🟢 99 🟢 100 🟢 100 🟢 100
/blog/btrblocks-compressor desktop 🟢 100 🟢 100 🟢 100 🟢 100
/blog/btrblocks-compressor mobile 🟢 96 🟢 100 🟢 100 🟢 100
/faq desktop 🟢 100 🟢 100 🟢 100 🟢 100
/faq mobile 🟢 96 🟢 100 🟢 100 🟢 100

Run 44920809232 · 2026-11-21 15:46 UTC

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T15:46:19.688086Z f09216d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7fbe334515

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/bench/lib/chart-format.ts Outdated
Comment on lines +261 to +262
if (format.startsWith(`${VORTEX_FORMAT} [`)) {
return `vortex${format.slice(VORTEX_FORMAT.length)}`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply the rename in per-group filter chips

When the per-group “Filter series” panel is opened for these new scan formats, this rename is bypassed: GroupToolbar.tsx renders format macro values directly at line 298 and hydrated series labels directly at line 210. Consequently the same series that appears as duckdb:vortex [file, v1] in the chart and summary still appears as vortex-file-compressed [file, v1] / duckdb:vortex-file-compressed [file, v1] in that filter; route those two visible strings through displayFormat and displaySeriesLabel while retaining the raw values for filtering.

Useful? React with 👍 / 👎.

The SQL benchmarks record Vortex's other scans as the format followed by
the integration and scan engine, as `vortex-file-compressed [file, v1]`.
bench drew each as its own series and ranked it in the summary cards. The
pull request reports compare those scans with their develop baseline in
bench's database, so the rows stay there, but bench now leaves them out of
the charts, the summaries, and the Format filter. This replaces the
previous commit, which only renamed them.

Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning lwwmanning changed the title Call each Vortex scan vortex on bench, not vortex-file-compressed Show only each suite's default Vortex scan on bench Nov 21, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1064ef2d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

* there, but bench shows only the default scan, as `vortex`.
*/
export function isOtherScan(format: string): boolean {
return / \[[^\]]+\]$/.test(format);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict the scan predicate to Vortex formats

isOtherScan currently classifies every format ending in a bracketed qualifier as an alternate Vortex scan, even though the documented convention is specifically vortex-file-compressed [...]. Because this predicate is used by recordRow for all chart families and by collectFilterUniverse, any legitimate non-Vortex format such as parquet [custom] is silently removed from charts and filter chips; require the vortex-file-compressed [ prefix before matching the suffix.

Useful? React with 👍 / 👎.

Comment thread src/bench/lib/queries.ts
Comment on lines +415 to +416
if (format !== undefined && isOtherScan(format)) {
return;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Drop charts that contain only hidden scans

When a discovered query has rows only for an alternate Vortex scan—for example after the default scan fails or is not emitted—the seed/total_commits queries still count those rows, but recordRow drops every one of them here. Both chartPayload and groupChartPayloads consequently return a non-null payload with an empty series object, so collectGroupCharts retains and renders a blank chart rather than omitting it; exclude hidden formats when determining chart existence or return null when filtering leaves no series.

Useful? React with 👍 / 👎.

…fect

The Data Cache outlives a deploy. With the same keys, a new deployment kept
serving the group summaries, chart payloads, and filter universe that the
old code computed, so the other Vortex scans still showed. The chart
payload and filter universe keys now carry the version too.

Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
@lwwmanning
lwwmanning enabled auto-merge (squash) November 21, 2026 15:48
@lwwmanning
lwwmanning merged commit cf66bf3 into main Nov 21, 2026
28 checks passed
@lwwmanning
lwwmanning deleted the wm/vortex-scan-display-names branch November 21, 2026 15:48

This branch was successfully deployed

1 active deployment
Preview — f09216d9 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant