Repository navigation
Show only each suite's default Vortex scan on bench - #233
Conversation
develop now runs Vortex's other scans as formats such as vortex-file-compressed [file, v1]. The display rename matched only the bare format, so those series showed the legacy name. They now read vortex [file, v1] on charts and summaries, and Vortex (file, v1) in llms.txt. Signed-off-by: Will Manning <will@willmanning.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔦 Lighthouse audit
Run |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fbe334515
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (format.startsWith(`${VORTEX_FORMAT} [`)) { | ||
| return `vortex${format.slice(VORTEX_FORMAT.length)}`; |
There was a problem hiding this comment.
Apply the rename in per-group filter chips
When the per-group “Filter series” panel is opened for these new scan formats, this rename is bypassed: GroupToolbar.tsx renders format macro values directly at line 298 and hydrated series labels directly at line 210. Consequently the same series that appears as duckdb:vortex [file, v1] in the chart and summary still appears as vortex-file-compressed [file, v1] / duckdb:vortex-file-compressed [file, v1] in that filter; route those two visible strings through displayFormat and displaySeriesLabel while retaining the raw values for filtering.
Useful? React with 👍 / 👎.
The SQL benchmarks record Vortex's other scans as the format followed by the integration and scan engine, as `vortex-file-compressed [file, v1]`. bench drew each as its own series and ranked it in the summary cards. The pull request reports compare those scans with their develop baseline in bench's database, so the rows stay there, but bench now leaves them out of the charts, the summaries, and the Format filter. This replaces the previous commit, which only renamed them. Signed-off-by: Will Manning <will@willmanning.io>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1064ef2d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * there, but bench shows only the default scan, as `vortex`. | ||
| */ | ||
| export function isOtherScan(format: string): boolean { | ||
| return / \[[^\]]+\]$/.test(format); |
There was a problem hiding this comment.
Restrict the scan predicate to Vortex formats
isOtherScan currently classifies every format ending in a bracketed qualifier as an alternate Vortex scan, even though the documented convention is specifically vortex-file-compressed [...]. Because this predicate is used by recordRow for all chart families and by collectFilterUniverse, any legitimate non-Vortex format such as parquet [custom] is silently removed from charts and filter chips; require the vortex-file-compressed [ prefix before matching the suffix.
Useful? React with 👍 / 👎.
| if (format !== undefined && isOtherScan(format)) { | ||
| return; |
There was a problem hiding this comment.
Drop charts that contain only hidden scans
When a discovered query has rows only for an alternate Vortex scan—for example after the default scan fails or is not emitted—the seed/total_commits queries still count those rows, but recordRow drops every one of them here. Both chartPayload and groupChartPayloads consequently return a non-null payload with an empty series object, so collectGroupCharts retains and renders a blank chart rather than omitting it; exclude hidden formats when determining chart existence or return null when filtering leaves no series.
Useful? React with 👍 / 👎.
…fect The Data Cache outlives a deploy. With the same keys, a new deployment kept serving the group summaries, chart payloads, and filter universe that the old code computed, so the other Vortex scans still showed. The chart payload and filter universe keys now carry the version too. Signed-off-by: Will Manning <will@willmanning.io>
Signed-off-by: Will Manning <will@willmanning.io>
This changes which Vortex series bench shows on its charts, summary cards, and Format filter. It does not change the database or the ingest.
Before, bench drew each of Vortex's other scans as its own series. For example, the ClickBench summary had
duckdb:vortex-file-compressed [file, v1]besideduckdb:vortex. vortex-data/vortex#11685 added these scans on develop. After, bench shows one Vortex series for each engine, the suite's default scan, asvortex.The rows stay in the database, because the pull request benchmark reports read their develop baseline from it and compare every scan. The methodology page now says which scan bench shows.
🤖 Generated with Claude Code