Skip to content

SoundWire: updates from Bard and Shuming - #2620

Closed
plbossart wants to merge 2 commits into
thesofproject:topic/sof-devfrom
plbossart:sdw/bard-shuming-updates
Closed

plbossart wants to merge 2 commits into
thesofproject:topic/sof-devfrom
plbossart:sdw/bard-shuming-updates

Conversation

@plbossart

Copy link
Copy Markdown
Member

simple patches extracted from PR2063 for faster merge while we debug timeouts.

shumingfan and others added 2 commits December 10, 2020 13:19
Intel validation reports a 'calibration timeout'. Dynamic debug logs
show the power state was changed to D3, let's make sure this cannot
happen while the calibration is run.

BugLink: thesofproject#2611
Signed-off-by: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Optimize the logic a bit, we don't have to reset unattach_request
after the regmap_sync tag since we only jump to regmap_sync when
unattach_request is 0.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@plbossart
plbossart force-pushed the sdw/bard-shuming-updates branch from 11aff27 to ed02692 Compare December 10, 2020 19:19
Comment thread sound/soc/codecs/rt711.c
break;
}

mutex_lock(&rt711->calibrate_mutex);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shumingfan Does rt711_set_bias_level() needs the mutex, too?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao Right, rt711_set_bias_level() should need the mutex. Thanks.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao if you want to close that PR and add a new one with more fixes that's fine with me. I am running out of time.

@bardliao

Copy link
Copy Markdown
Collaborator

replaced by #2625

@bardliao bardliao closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants