Repository navigation
Conversation
plbossart
requested review from
RanderWang,
bardliao,
dbaluta,
jack-cy-yu,
kv2019i,
lgirdwood,
naveen-manohar,
oder-chiou,
ranj063,
ryans-lee and
shumingfan
as code owners
December 10, 2020 19:18
Intel validation reports a 'calibration timeout'. Dynamic debug logs show the power state was changed to D3, let's make sure this cannot happen while the calibration is run. BugLink: thesofproject#2611 Signed-off-by: Shuming Fan <shumingf@realtek.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Optimize the logic a bit, we don't have to reset unattach_request after the regmap_sync tag since we only jump to regmap_sync when unattach_request is 0. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
plbossart
force-pushed
the
sdw/bard-shuming-updates
branch
from
December 10, 2020 19:19
11aff27 to
ed02692
Compare
bardliao
reviewed
Dec 11, 2020
| break; | ||
| } | ||
|
|
||
| mutex_lock(&rt711->calibrate_mutex); |
Collaborator
There was a problem hiding this comment.
@shumingfan Does rt711_set_bias_level() needs the mutex, too?
There was a problem hiding this comment.
@bardliao Right, rt711_set_bias_level() should need the mutex. Thanks.
Member
Author
There was a problem hiding this comment.
@bardliao if you want to close that PR and add a new one with more fixes that's fine with me. I am running out of time.
Collaborator
|
replaced by #2625 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple patches extracted from PR2063 for faster merge while we debug timeouts.