You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Opens:
a) is this really an error? the status of rt711_calibration() is not tested by anyone
b) is this really good to use the same function directly and with a workqueue? This code seems suspicious:
On init we use a work queue but later we call the function directly?
Should we always rely on schedule_work(), so that during remove/suspend we wait for the calibration to be finished? If the calibration is handled directly it's not clear what happens?
@plbossart@bardliao I just want to save time for system boot, so I use the schedule_work() for the first time.
If the driver re-do the io_init after the system resumes, I want to make sure the calibration is done before the playback/capture operations.
I think this issue could be caused by the power state of the codec. The power state was changed to D3 in the put function of kcontrol.
Could you test again with the following patch?
Activity
plbossart commentedon Dec 8, 2020
@bardliao @shumingfan @RanderWang @jack-cy-yu FYI
bardliao commentedon Dec 9, 2020
I see below in the dmesg.
Do we need to use mutex here?
shumingfan commentedon Dec 9, 2020
@plbossart @bardliao I just want to save time for system boot, so I use the schedule_work() for the first time.
If the driver re-do the io_init after the system resumes, I want to make sure the calibration is done before the playback/capture operations.
I think this issue could be caused by the power state of the codec. The power state was changed to D3 in the put function of kcontrol.
Could you test again with the following patch?
ASoC: codecs: rt711: mutex between calibration and power state changes
ASoC: codecs: rt711: mutex between calibration and power state changes
ASoC: codecs: rt711: mutex between calibration and power state changes
ASoC: codecs: rt711: mutex between calibration and power state changes
ASoC: codecs: rt711: mutex between calibration and power state changes
ASoC: codecs: rt711: mutex between calibration and power state changes
plbossart commentedon Dec 11, 2020
#2626
mengdonglin commentedon Dec 14, 2020
@plbossart @bardliao Can we close this issue as #2626 got merged?
bardliao commentedon Dec 14, 2020
Let's check the test result for few more days. We can close the issue if we don't see it in our daily test.
bardliao commentedon Dec 17, 2020
Not reproduce in recent test report.
shumingfan commentedon Dec 21, 2020
The patch was merged to the for-next branch.
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=6108f990c0887d3e8f1db2d13c7012e40a061f28