Repository navigation
Conversation
The state machine requires that we first initialize the device after attachment before dealing with alerts. Add an error case if that isn't the case. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/debug-suspend-resume
branch
from
December 7, 2020 18:07
efc158d to
1fc9c63
Compare
Optimize the logic a bit, we don't have to reset unattach_request after the regmap_sync tag since we only jump to regmap_sync when unattach_request is 0. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Add a dev_dbg() log for both enumeration and initialization completion to better track suspend-resume issues. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
this is very verbose but may be useful to track update_status() progress Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
make sure the suspend timeout is properly managed. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
let's see what happens with resume operations. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Check if there is any issue with system resume? Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fix potential race condition by preventing the pm_runtime resume from being executed while system resume is taking place. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
When the pm_runtime status is forced active in a child device, the following error is thrown: [ 6239.434332] kernel: rt711-sdca sdw:0:25d:711:1: runtime PM trying to activate child device sdw:0:25d:711:1 but parent (sdw-master-0) is not active Add the same fix to force pm_runtime status as active when doing a system resume. FIXME: is there a better way of doing this? Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
add traces and force pm_runtime status to be active on system resume. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Intel validation reports a 'calibration timeout'. Dynamic debug logs show the power state was changed to D3, let's make sure this cannot happen while the calibration is run. BugLink: thesofproject#2611 Signed-off-by: Shuming Fan <shumingf@realtek.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
sdw/debug-suspend-resume
branch
from
December 9, 2020 03:57
f3ec254 to
76f0080
Compare
This was referenced Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set of traces added to show race condition between system and pm_runtime resume