Repository navigation
Feature/1854 OpenCL /prim signatures part 2 - #1869
Conversation
…4.1 (tags/RELEASE_600/final)
…s/RELEASE_600/final)
…4.1 (tags/RELEASE_600/final)
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
# Conflicts: # stan/math/opencl/kernel_generator/binary_operation.hpp # stan/math/opencl/kernel_generator/unary_function_cl.hpp # stan/math/opencl/opencl.hpp # stan/math/opencl/prim/inv.hpp
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
|
This is ready for review. |
…4.1 (tags/RELEASE_600/final)
t4c1
left a comment
There was a problem hiding this comment.
Looks good! Optionally we can replace auto return type with explicitly specified types on functions that return matrices.
Co-authored-by: Tadej Ciglarič <tadej.c@gmail.com>
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Summary
This PR builds on #1859 and does the following changes to the /prim support in OpenCL:
Tests
All new functions have tests.
Side Effects
/
Release notes
Renamed elewise_multiplication/elewise_division to elt_multiply/elt_divide in the kernel generator and added OpenCL support to /prim functions crossprod, tcrossprod, fabs, log1m_inv_logit, logit, divide
Checklist
Math issue Implement matrix_cl overloads for prim & rev functions #1854
Copyright holder: Rok Češnovar
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested