Repository navigation
Feature/1854 OpenCL /prim signatures part 1 - #1859
Conversation
…4.1 (tags/RELEASE_600/final)
SteveBronder
left a comment
There was a problem hiding this comment.
Made a first pass with some Qs. Think @t4c1 is better reviewing this
| namespace stan { | ||
| namespace math { | ||
|
|
||
| /** \ingroup opencl |
There was a problem hiding this comment.
Should these be in a sub group like methods?
There was a problem hiding this comment.
I could go with a prim subgroup. These are all just trying to add every missing prim signature in the Stan language. I dont think this will be used inside Math directly, much like the regular prim/col is not.
| * assigning the resulting expression to a matrix_cl representing | ||
| * a column vector. | ||
| * | ||
| * @tparam T type of the matrix |
There was a problem hiding this comment.
T_a, double check the docs for all these
|
Thanks @SteveBronder for the initial feedback. Addressed all your points. So I guess @t4c1 can take a look when he has time. |
# Conflicts: # stan/math/opencl/kernel_generator/block.hpp
|
@serban-nicusor-toptal it seems that all Linux workers are offline: |
|
Good morning @rok-cesnovar Jenkins should take care of this by itself and scale through aws instances. |
Co-authored-by: Tadej Ciglarič <tadej.c@gmail.com>
Co-authored-by: Tadej Ciglarič <tadej.c@gmail.com>
Co-authored-by: Tadej Ciglarič <tadej.c@gmail.com>
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
|
@SteveBronder you good with this? Cant merge as your change request is still there. If you dont have any more comments, please go ahead and merge. Thanks! |
Summary
Add /prim OpenCL support for the following functions (only matrix ones listed, but this also adds the same signatures for row_vector and vector):
This adds no new OpenCL code, just using the generator.
It also adds argument checks to block(), renames
is_valid_expressiontois_valid_kernel_expression,require_all_valid_expressions*torequire_all_valid_kernel_expressions*Tests
Added tests for all added functions.
Side Effects
/
Release notes
Added OpenCL support for prim versions of add, col, inv, inv_cloglog, inv_logit, inv_sqrt, inv_square, row, dims, cols.
Added argument checks to OpenCL version of block() and renamed
is_valid_expressiontois_valid_kernel_expressionandrequire_all_valid_expressions*torequire_all_valid_kernel_expressions*.Checklist
Math issue Implement matrix_cl overloads for prim & rev functions #1854
Copyright holder: Rok Češnovar
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested