This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 16, 2020. It is now read-only.
partialResults are sent when clientCapabilities do not support them #329
Description
Hooking up this language server to Atom right now and finding a ton of out-of-spec partialResult messages being returned. Wondering if this is a cause of some slow perf we're seeing but am unable to switch them off to see.
It looks like the intent was that the clientCapabilities has a streaming property which defines when these messages are supposed to be sent but it isn't yet honored.
Activity
tomv564 commentedon Aug 8, 2017
I brought this up in #298 because I thought it would be a significant effort.
Looking at the TODO mentioned in that issue (https://github.com/sourcegraph/javascript-typescript-langserver/blob/master/src/connection.ts#L257-L282) it does not look that hard to fix!
felixfbecker commentedon Aug 11, 2017
I don't think that sending these notifications are a problem. VS Code sends a lot of non-specced notifications like
$/traceand the server also resendstextDocument/publishDiagnosticsand those are not a problem. Message handling in the client shouldn't be the bottleneck or there is more likely something wrong with the client. That said, I don't have a problem with checking the flag there and would accept a PR, that's what it's for after all.tomv564 commentedon Aug 20, 2017
I think this specific issue can be closed, the performance discussion continues in #331
damieng commentedon Aug 20, 2017
I still think this is an issue. Emitting unwanted out-of-spec messages is quite annoying from the client side especially if you have debugging on, it makes it a real pain to see what's going on. It's also a pretty easy fix - I have one incoming.
felixfbecker commentedon Aug 20, 2017
It is already fixed in 2b68b48
damieng commentedon Aug 21, 2017
Great, thanks. I had that piece but didn't manage to get tests working.