Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Move method implementations into own files #298

Open

Description

@felixfbecker

TypeScriptService has grown in size over time. I would like to add a folder "features" that contains one file per feature with e.g. a "ReferenceProvider" class. The TypeScriptService would merely call these and map the returned Observables to JSON Patches.

Activity

  1. tomv564 commented on Aug 7, 2017

    @tomv564
    Contributor

    Would be a good opportunity to honour the streaming setting in ClientCapabilities! (Make the Observable consumption swappable between json-patch and the old behaviour)

  2. felixfbecker commented on Aug 7, 2017

    @felixfbecker
    ContributorAuthor

    I don't think this refactor makes a difference for that - the current behaviour is to send both the partial results and the final result. Can't change that right now because our client implementation sometimes relies on the final result. The change would be only in connection.ts (there is a TODO comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions